? ? ?
avatar brianteeman
brianteeman
18 Dec 2020

See #31641 for details

There is a bug in com_csp in that it is only showing the domain root which is not the same as the site root AND it is not showing the actual url

screenshot

avatar brianteeman brianteeman - open - 18 Dec 2020
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Dec 2020
avatar HLeithner HLeithner - change - 18 Dec 2020
Labels Added: ?
avatar HLeithner HLeithner - labeled - 18 Dec 2020
avatar rdeutz rdeutz - change - 20 Dec 2020
Labels Added: ?
avatar rdeutz rdeutz - labeled - 20 Dec 2020
avatar bembelimen
bembelimen - comment - 28 Dec 2020

Just for documentation, as I'm not sure why it's done that way:
here the full URL is available but only the domain is saved. As @zero-24 did a lot of changes here, perhaps he can explain?

avatar zero-24
zero-24 - comment - 28 Dec 2020

Solution is here: #31641 (comment) ;-)

We just need to have someone with the time to make a PR with that changes.

avatar bembelimen
bembelimen - comment - 28 Dec 2020

Two things I don't like at the solution:

  1. it uses parse_url instead of Uri (internal checks etc.)
  2. Wildly saving a full url with all parameters looks for me like a good way to open up a gate for potential XSS as any URL can be send in the request + there is a high potential that an admin opens the url to check the page for the stuff, because the list is really lacking important information (which script etc)
avatar zero-24
zero-24 - comment - 28 Dec 2020

Agree feel free to send a PR that uses uri vs parse_url.

Wildly saving a full url with all parameters looks for me like a good way to open up a gate for potential XSS as any URL can be send in the request + there is a high potential that an admin opens the url to check the page for the stuff, because the list is really lacking important information (which script etc)

Agree on the XSS stuff any ideas to solve it?

There is an issue open on the CSP specs site. Right now we could only get a short part of the script but not the full or even better the script hash to whitelist it.
w3c/webappsec-csp#378

avatar brianteeman
brianteeman - comment - 31 Dec 2020

With

  • the absence of URL being displayed
  • the lack of info about which script
  • the potential for serious xss issues if the url is displayed
  • the absence of any helpful information suitable for the typical Joomla user
    this should be removed from 4.0 and pushed back to 4.1. Its just nowhere near release ready sadly
avatar brianteeman
brianteeman - comment - 19 Feb 2021

Trying to use this in the real world and even on a site that only has five pages the reports are completely useless

image

avatar zero-24
zero-24 - comment - 19 Feb 2021

Agree thats the reason i proposed the change that still allows the full url to be shown as before the other PR.

avatar rdeutz rdeutz - change - 29 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-29 08:44:07
Closed_By rdeutz
Labels Added: ? ?
Removed: ? ?
avatar rdeutz rdeutz - close - 29 Mar 2021
avatar rdeutz
rdeutz - comment - 29 Mar 2021

closing as we have a PR #32893

avatar rdeutz rdeutz - unlabeled - 29 Mar 2021

Add a Comment

Login with GitHub to post a comment