The menu items are correct now but the typography link is now index.php?itemid=106

the $headerLink needs to be something like
$headerLink = 'index.php?option=com_content&view=article&id=' . $articleIds[10] . '&catid=' . $catIds[4];
but I couldnt get the value of the catid. Must be missing something obvious.

@brianteeman changed as desired. The categoryIds were missing in step 3 ...

I have tested this item ✅ successfully on 42362d8

@brianteeman I'd be happy if you could find some time and test @chmst 's PR here. Thanks in advance.

Title missing for Special Menu Module

Use access levels for changing login / logout links in top menu and footer menu #32556

@chmst Does your last change close issue #32556 ?

@infograf768 this was intended as example for a module without title.

Don't activate workflow automatically. #32387

While trying to login, facing a 404.

Steps to reproduce:

• Go the landing page.
• Click on login tab.
• Use the login form on the right.

Side notes: The same issue doesn't seem to happen with the form on the left. The form on the left redirects to home page.

Details about system:
I'm currently on Windows 10, using WAMP server. I can confirm this issue for both latest Mozilla Firefox and Microsoft Edge.

I used a fresh installation of Joomla 4.0.8 Nightly with a new database. Next, I installed the patch tester and applied the patch. Lastly, I installed the Sample Blog Data.

The expected behavior is that the user is redirected to either home page or profile page.

@sksuryan thank you for testing. I have repeated your test and it is only if the active view is the login view, right?

Yes.
Also, I'm a little confused. I don't understand why do we need two login forms? If I'm not wrong, the form on the right is the part of the standard sidebar which we see on every page, but it kind of looks redundant here.

Yes.
Also, I'm a little confused. I don't understand why do we need two login forms? If I'm not wrong, the form on the right is the part of the standard sidebar which we see on every page, but it kind of looks redundant here.

You don't need to have the two... the one is a module, the other is the view of a component. You can use whatever suit better for you, but in sample data we have the two alternatives to show what is possible.

If I'm not wrong, the form on the right is the part of the standard sidebar which we see on every page, but it kind of looks redundant here.

That login module may be published or not and, if published, not on every page.
Also, when one is using, for example, a readmore which needs user to be logged, it is the login menu item form which is presented to the user to fill, and not the module. ;)

Yes.
Also, I'm a little confused. I don't understand why do we need two login forms? If I'm not wrong, the form on the right is the part of the standard sidebar which we see on every page, but it kind of looks redundant here.

You don't need to have the two... the one is a module, the other is the view of a component. You can use whatever suit better for you, but in sample data we have the two alternatives to show what is possible.

If I'm not wrong, the form on the right is the part of the standard sidebar which we see on every page, but it kind of looks redundant here.

That login module may be published or not and, if published, not on every page.
Also, when one is using, for example, a readmore which needs user to be logged, it is the login menu item form which is presented to the user to fill, and not the module. ;)

okay, yes that actually makes a lot of sense. thank you!

It is confusing.
When Joomla is installed, a main menu (home) and a login module are stored. This is independent of blog sample data. I don't know if there is a reason in history why the login module is added during installation. As @infograf768 says, login and logout is necessary, but if it is needed for installaition?

Blog Sample Data are optional and should show how modules can be added to front-and backend, and especially how Login and Logout can be changed using user groups.

I don't know if there is a reason in history why the login module is added during installation.

No good reason

To resolve the #31711 (comment) the login module is now hidden on login view.

I have tested this item ✅ successfully on 88293c3

Tested it successfully on Joomla! 4.0.0-beta8-dev ,php 8.0.0

I have tested this item ✅ successfully on 88293c3

RTC

Back to pending - the admin menu looks strange and needs new tests.

@chmst Some Questions about "Actual result BEFORE applying this Pull Request"

Backend:

• There is a menuItem anf a module "Author menu"

Found only menu "Admin Menu", module has title "Author menu".

• There are some menuItems where the link contains "id=id="

Found this menus, are there more?

1. About your home page, id=119
2. Millions, id=121
3. Love, id=122
4. Typography, id=106

Frontend:

• If the user logs out, a 404 occurs

How to get a 404, #31711 (comment) don't bring 404 up.
Test Login and -out at Menu Home and Module Login Form didn't get the 404. Maybe solved elsewhere?

Sorry for wrong test, i test only issue #32991.

I have tested this item ✅ successfully on 4d3ac23

@chmst can you please answer #31711 (comment) so i can do a test?

I have tested this item ✅ successfully on 4d3ac23

RTC

RTC

@sandramay0905 thank you very much for testing and sorry for delay.

Found only menu "Admin Menu", module has title "Author menu".

Correct. The name of the module must not be the same as the link. The title of the module is not shown in the frontend, this is intended.

Found this menus, are there more?

There were 4 menuItems - but which IDs they have depends on your installation. A user can work in an application before adding the sample data and then IDs are different.

Test Login and -out at Menu Home and Module Login Form didn't get the 404. Maybe solved elsewhere?

I also cannot reproduce this effect with 404. It leads me now to the profile page (which is nearly as bad as 404). So probably one of the recent PRs has fixed this.