? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
15 Dec 2020

Summary of Changes

remove comment from c&p mistake

Testing Instructions

code review

avatar alikon alikon - open - 15 Dec 2020
avatar alikon alikon - change - 15 Dec 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Dec 2020
Category Administration com_content
avatar HLeithner
HLeithner - comment - 15 Dec 2020
avatar alikon
alikon - comment - 15 Dec 2020

Sorry didn't understand i've changed only 1 file this administrator/components/com_content/src/Model/ArticleModel.php

how it can be related to the drone report
image

avatar richard67
richard67 - comment - 15 Dec 2020

@HLeithner Drone PHPCS is currently failing in the 4.0-dev branch with the same result: https://ci.joomla.org/joomla/joomla-cms/38216/1/6 . So it's not related to this PR, and the branch of this PR is up to date.

avatar richard67 richard67 - test_item - 15 Dec 2020 - Tested successfully
avatar richard67
richard67 - comment - 15 Dec 2020

I have tested this item successfully on e32dc05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31659.

avatar toivo toivo - test_item - 15 Dec 2020 - Tested successfully
avatar toivo
toivo - comment - 15 Dec 2020

I have tested this item successfully on e32dc05

Tested successfully in Beta6-dev of 15 December.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31659.

avatar alikon alikon - change - 15 Dec 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 15 Dec 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31659.

avatar richard67 richard67 - change - 15 Dec 2020
Labels Added: ? ?
avatar SharkyKZ
SharkyKZ - comment - 15 Dec 2020

What was that about not setting RTC on PRs with failing tests? ?

avatar richard67
richard67 - comment - 15 Dec 2020

As I stated above, failing tests are not related to this PR but to the 4.0-dev branch.

avatar HLeithner HLeithner - close - 15 Dec 2020
avatar HLeithner HLeithner - merge - 15 Dec 2020
avatar HLeithner
HLeithner - comment - 15 Dec 2020

Thanks

avatar HLeithner HLeithner - change - 15 Dec 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-12-15 17:23:33
Closed_By HLeithner
Labels

Add a Comment

Login with GitHub to post a comment