User tests: Successful: Unsuccessful:
Pull Request for Issue #31657
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
No worries, I created the issue first and decided to fix it myself.
Wouldn't that mean the tiny MCE has an error?
The field is now valid html
I cannot reproduce your issue, with note field I have markup:
<div class="control-group">
<div class="control-label">
</div><div ><h4>test</h4></div>
<div class="controls">
</div>
</div>
The closing div inside the filed is hacky way to make the note full width: close previous div, and reopen it after the note again.
Changes in this PR break it.
The closing div inside the filed is hacky way to make the note full width: close previous div, and reopen it after the note again.
That makes sense for how it currently works. I'm using these fields on the front end in a twig template and they aren't wrapped in the usual divs for admin pages. Looks like I'll need to create a custom note form field.
Something to consider for an update on this field, would it be possible to add an attribute that defaults to the current output and when the attribute is set switches to the stand alone html?
Currently I'm thinking something like
html=strict (standard valid html)
Or
html=wrapped (set by default)
Do not need any extra attributes, there already layout
attribute, that allows to use a custom markup.
However the Note field does not support it currently. The solution would be is to make support a custom layout in this field.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-18 04:17:28 |
Closed_By | ⇒ | venomdev | |
Labels |
Added:
?
|
@venomdev you can close #31657. It don“t need an issue if a pr is created.