[#31660] - [4.0] Refactor JInstaller strings
- Fixed in Code Base
- 17 Dec 2020
- Medium
- Build: 4.0-dev
- # 31660
- Diff
- Bakual:4_JInstaller_Strings
User tests: Successful: Unsuccessful:
Currently, the language file lib_joomla.ini contains several strings which basically have the same error message, but for the different types of extensions.
Many of the strings already aren't used anymore since a generic "extension install failed..." type of the string exists.
Summary of Changes
- Removed the unused strings.
- Changed the ones still used to the more generic "extension" string
- Used the variable for the type of installation (install, uninstall, update, discover_install) which allowed to reduce the string amount as well
Testing Instructions
You would need to have an extension package which is broken (eg files missing) or a server with wrong folder permissions (not able to write) to get errors
Imho it should be fine to do a code review as I'm not changing any functionality itself.
Actual result BEFORE applying this Pull Request
Error messages are sometimes specific to the type of extension (template, file, library, component, plugin, module, package)
Expected result AFTER applying this Pull Request
Error messages are more generic.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Language & Strings Installation Libraries |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||
Rebased PR on latest 4.0-dev
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-17 15:22:38 |
| Closed_By | ⇒ | wilsonge |
Makes lots of sense to me!
@Bakual The phpcs failure in Drone is not related to your PR, it comes from the 4.0-dev branch having had code style errors when you had created your branch based on it. But if you want to get rid of the Drone failure, update your branch to latest 4.0-dev, where the errors meanwhile have been corrected.