[#31599] - [4.0] Fix local adapter, keep fixed ordering, fix default value
- Fixed in Code Base
- 23 Jan 2021
- Medium
- Build: 4.0-dev
- # 31599
- Diff
- Fedik:adapter-local
User tests: Successful: Unsuccessful:
Pull Request for Issue from comment #26750 (comment) .
Summary of Changes
Do not allow User to change ordering in the plugin parameters.
local-0:/, local-1:/ ... local-x:/ always should stay in original order.
I more like idea with named prefix <provider>-<account>, as @dgrammatiko suggested in #26750 (comment).
However this will not work, I not checked in deep but it seems that whole thing hardcoded to use <account> as integer.
Also I have fixed default value.
Testing Instructions
Apply path.
Go to Plugins: FileSystem - Local.
Add couple Directories, and try change their order.
Actual result BEFORE applying this Pull Request
You can change ordering
Expected result AFTER applying this Pull Request
You cannot change ordering
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I didn't test, but looks fine for me...
I have created folders with PR applied, but they remain fixed.
I don't know how to vary the order.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31599.
I have tested this item
I can confirm the pull request removes the ordering thingy. But:
Can someone explain why this matters and how this plugin is supposed to be used? The Help screen is rubbish - I will fix it when I know more.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31599.
Can someone explain why this matters
It a bit tricky, as whole Adapters thing
There a bit #26750 (comment)
User can add some own folders here (many of them), that the system will see like 0, 1, 2 ... n (it is actual a Row indexes). If User change ordering, then association "Row Index" => "Row value" also will change, that will break previous stored values.
how this plugin is supposed to be used?
That a good question
It something for Media manager. I not searched, but I hope there a documentation.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31599.
I have changed the Media Help screen to read as follows:
LOCAL Panel
This area shows the structure of the local folders of your site, by default the images folder.
If you wish to keep images and documents in separate local folders: first create a folder in
the root of your site, say files, then go to the Filesystem - Local plugin and add files under
Select directories. Back in the Media component you will see images and files as separate
items in the Local panel.
Which means that the Media Options descriptors are incorrect.
It will take a while for the change to pass through the translation system.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31599.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-23 20:46:23 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Thanks!
@laoneo can you have a look at this one?