? ?
avatar jsubri
jsubri
6 Dec 2020

Steps to reproduce the issue

/administrator/index.php?option=com_installer&view=update
Try to update an "old" extension that will result in "Error updating COM_INSTALLER_TYPE_TYPE_."

Expected result

No PHP Warning

Actual result

[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Trying to access array offset on value of type bool in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 451, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update
[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Trying to access array offset on value of type bool in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 454, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update
[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Trying to access array offset on value of type bool in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 464, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update
[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Trying to access array offset on value of type bool in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 469, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update
[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Trying to access array offset on value of type bool in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 486, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update
[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Trying to access array offset on value of type bool in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 495, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update
[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Trying to access array offset on value of type bool in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 498, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update
[Sun Dec 06 11:42:14.535136 2020] [php:warn] [pid 10524:tid 1808] [client ::1:58021] PHP Warning: Undefined array key "extractdir" in C:\xampp3\htdocs\test-php8\administrator\components\com_installer\models\update.php on line 501, referer: http://localhost/test-php8/administrator/index.php?option=com_installer&view=update

System information (as much as possible)

xampp-windows-x64-8.0.0-0-VS16-installer.exe
Windows 10
PHP 8.0.0
Joomla 3.9.23

Additional comments

avatar jsubri jsubri - open - 6 Dec 2020
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Dec 2020
avatar jsubri jsubri - change - 6 Dec 2020
The description was changed
avatar jsubri jsubri - edited - 6 Dec 2020
avatar Quy Quy - change - 6 Dec 2020
Labels Added: ?
avatar Quy Quy - labeled - 6 Dec 2020
avatar jsubri
jsubri - comment - 7 Dec 2020

Not only PHP8, I've the warnings on PHP 7.4 too

avatar HLeithner
HLeithner - comment - 7 Dec 2020

Hi @jsubri

could you please edit line 448 with var_dump($package) because it looks like th extraction of the package fails and we don't check if the unpacking was successful.

Can you upload the extension package you want to install?

thx

avatar jsubri
jsubri - comment - 7 Dec 2020
avatar infograf768
infograf768 - comment - 8 Dec 2020

php 7.3.9
with J3 I do get a possible update and then get Error updating COM_INSTALLER_TYPE_TYPE_
in J4 with php 7.39 no update shows in the manager,

avatar HLeithner
HLeithner - comment - 8 Dec 2020

@jsubri can you try this with the latest nightly ? maybe the extension installation pr fixes this too.

avatar jsubri
jsubri - comment - 8 Dec 2020

@HLeithner , I've applied Joomla! 3.9.24-dev with the nightly "Tuesday, 08 December 2020 03:00:08 UTC"
Edited: same error on PHP not 7.3.4 but 7.4

avatar N6REJ
N6REJ - comment - 8 Dec 2020

I've tested this everyway I can think of and can't replicate it.

avatar infograf768
infograf768 - comment - 9 Dec 2020

I confirm the warnings in the php error log on php 7.4.2 with J 3.9.24-dev

avatar infograf768
infograf768 - comment - 9 Dec 2020

Patch coming

avatar infograf768
infograf768 - comment - 9 Dec 2020

Closing as we have a patch
Please test #31620

avatar infograf768 infograf768 - close - 9 Dec 2020
avatar infograf768 infograf768 - change - 9 Dec 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-12-09 11:01:15
Closed_By infograf768

Add a Comment

Login with GitHub to post a comment