[#31600] - Revert #31537 and fix warnings on php 8 in fof
- Fixed in Code Base
- 12 Dec 2020
- Medium
- Build: staging
- # 31600
- Diff
- Fedik:fix-fof-warning
User tests: Successful: Unsuccessful:
Pull Request for Issue #31537.
Summary of Changes
This revert changes in #31537, and make a better fix for that issue.
Testing Instructions
Please follow #31537 for test
Actual result BEFORE applying this Pull Request
much warning
Expected result AFTER applying this Pull Request
no warning
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
I have tested this item
✅ successfully on 4ecc31eWorks for warnings in php 7.4. They are no longer visible
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31600.
can you retest with php8 please.. This is specifically a php8 issue.
@Fedik I just did a clean pull & install for both staging and 4.0-dev and didn't see any warnings, without any pr's.
systeminfo-2020-12-06T12_36_19-06_00.txt
@N6REJ - you see the same errors as php 8 in php 7.4.12. See the original issue.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31600.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31600.
| Labels |
Added:
?
?
?
|
||
HLeithner
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-12 18:07:46 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
I have tested this item✅ successfully on 4ecc31e
Works for warnings in php 7.4. They are no longer visible
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31600.