[#31578] - [4.0] Add empty alt checkbox for tinyMCE dnd
- Fixed in Code Base
- 7 Dec 2020
- Medium
- Build: 4.0-dev
- # 31578
- Diff
- dgrammatiko:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Adds the checkbox for specifying that an image is decorative (alt=""). Feature parity with the rest fields, etc
Testing Instructions
Drag and drop an image in the tinyMCE, check or not the No Description checkbox (adding or not alt text) and observe the generated tag (just toggle the editor to do so)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
It either can be closed or someone needs to add the missing string here
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | JavaScript Repository NPM Change | ⇒ | Administration Language & Strings JavaScript Repository NPM Change |
| Labels |
Added:
?
|
||
| Category | JavaScript Repository NPM Change Administration Language & Strings | ⇒ | Administration Language & Strings JavaScript Repository NPM Change Front End Plugins |
| Title |
|
||||||
shawoman (shaman ?) said: title, description, testing instructions missing. Me go back to cavern and concentrate on cooking special poison to use on hunters arrows.
@infograf768 refresh...
Thanks for doing this. I was looking at it this morning but ran out of time.
Can you also do this for the xtd-editor plugin please
@brianteeman I thought I did that already @ #31425
@dgrammatiko sorry forgot you had done that
| Labels |
Added:
Conflicting Files
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31578.
I have tested this item
Done :)
Backend
FrontEnd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31578.
I have not tested this item.
sorry
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31578.
I have tested this item
done
backend
Frontend
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31578.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31578.
TEST:
drop an image for the first time: all works fine.
delete image in tinyMCE textarea and try again OR drop the same image in another article:
Error: Conflict
The issue is that the image is already uploaded to the images folder
I am setting this back to pending as it is impossible to use the same image via drag and drop more than once (when it is not already present in the folder) and the error displayed is unclear.
| Status | Ready to Commit | ⇒ | Pending |
back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31578.
@infograf768 that issue is totally unrelated to this pr, I’ll try to make a pr for that case but not gonna do it here
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-07 08:37:50 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Removed:
Conflicting Files
|
||
@dgrammatiko
agree. Same error without this PR. merged. tks.
Please try to solve asap ;)
Thanks for merging this
Called my shaman ( shawoman?): she entered into a transe, concentrated on the last mammoth hunt and collapsed, some code dripping from her twisted mouth...
Then, after recovering, she said : what the heck is that about?