[#31541] - [3x] and [4.0] RTL does not change names of sidebar-left and sidebar-right but does move physical position
- Closed
- 30 Nov 2020
- Medium
- Build: staging
- # 31541
Steps to reproduce the issue
View (change if necessary) the site in RTL mode.
Expected result
sidebar-left and sidebar-right (and their equivalents in J3) should stay on the left and right respectively.
Allocate a module to the sidebar-right position and it should display on the right and the reverse for sidebar-left position.
Actual result
sidebar-left moves to the right and sidebar-right moves to the left.
System information (as much as possible)
Additional comments
It may be for J3x that it's too late to change anything, but perhaps this could be addressed for J4.
joomla-cms-bot
- | Labels |
Added:
?
|
||
In protostar the positions in the template are called position-7 and position-8. Only in the english language file are they given the left and right strings. This was done deliberately because of the language direction
In cassiopeia the positions are called sidebar-left and sidebar-right. This is incorrect if the value of the language moves them. Left is still Left in arabic. So yes sidebar-first or sidebar-primary is the correct direction neutral terminology
I would like to do this but it must be planned with other changes in the installation database, as were already mentioned in the cassiopeia repo.
We could name the module positions sidebar-right-when-ltr-or-left-when-rtl and sidebar-left-when-ltr-or-right-when-rtl ;-)
(forgive me my silly joke)
We could name the module positions
sidebar-right-when-ltr-or-left-when-rtlandsidebar-left-when-ltr-or-right-when-rtl;-)(forgive me my silly joke)
Or maybe some code that reverses all sidebar-right to sidebar-left (and vice versa) when RTL is selected. But that would need the template's index.php and the templateDetails.xml to change as well.
No, we should do like Brian suggested and either use sidebar-firstand sidebar-last or sidebar-primary and sidebar-secondary.
But the first will maybe make people ask "if there is a first and a last, is there also something in the middle", and the second will maybe not be clear enough. But I don't have a better idea.
It is not needed in 3.x as explained above
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-30 17:00:44 |
| Closed_By | ⇒ | richard67 |
It is intended and correct that the sidebars change their position.
Maybe "sidebar-first" and "sidebar-second" following the direction of eye movement in the respective languages?
@infograf768