[#31542] - [4.0] Rename sidebar
- Closed
- 1 Dec 2020
- Medium
- Build: 4.0-dev
- # 31542
- Diff
- brianteeman:position
User tests: Successful: Unsuccessful:
This PR renames the module positions in the Cassiopeia template from sidebar-left and -right to sidebar-primary and -secondary
This is because when the language is changed from LTR to RTL the positions are moved and the names -left and -right are no longer applicable.
thanks to @Scrabble96 for spotting this
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql Language & Strings Front End Plugins Templates (site) NPM Change |
I thought about it and rejected it as potentially that is changing users data
I thought about it and rejected it as potentially that is changing users data
@brianteeman Then it should be documented and linked in the release announcement.
I will test this tomorrow.
-TPL_CASSIOPEIA_POSITION_SIDEBAR-LEFT="Sidebar-left"
-TPL_CASSIOPEIA_POSITION_SIDEBAR-RIGHT="Sidebar-right"
+TPL_CASSIOPEIA_POSITION_SIDEBAR-PRIMARY="Sidebar-primary"
+TPL_CASSIOPEIA_POSITION_SIDEBAR-SECONDARY="Sidebar-secondary"
is imho totally arbitrary and counter intuitive. Why would left be primary and right secondary?...
Looks like this is just splitting hairs for no real gain.
RTL users are not so idiots that they can't understand left and right will be reverted in rtl display.
Why should they have to think that left is right and right is left. Not surprised that you once again find a spurious reason to object
is imho totally arbitrary and counter intuitive. Why would left be primary and right secondary?...
Am just thinking about it .. maybe sidebar-1 and sidebar-2?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-01 09:31:41 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
@brianteeman I hope closing was not due to my last comment. I only thought about naming, not more.
@richard67 no not you
Maybe we should provide an update SQL for updating previous J4 Beta versions?