[#31539] - [4.0] Frontend Edit Article [a11y]
- Fixed in Code Base
- 7 Dec 2020
- Medium
- Build: 4.0-dev
- # 31539
- Diff
- brianteeman:edit_article
User tests: Successful: Unsuccessful:
Every field must have a label. This PR ensures that a label is rendered for the text editor. It is not visually displayed as it has a class sr-only so there is no visible change.
If you apply the PR and inspect the source of the edit article page you will see that a label has been added as shown in the screenshot below
cc @carcam
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content Language & Strings |
That is what renderfield does
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31539.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31539.
I have tested this item
Joomla! 4.0.0-beta6-dev Development [ Mañana ] 27-October-2020 19:54 GMT
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31539.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31539.
richard67
- | Labels |
Added:
?
?
?
|
||
@brianteeman
The hiddenLabel should be false or true?
<field
name="articletext"
type="editor"
label="COM_CONTENT_FIELD_ARTICLETEXT_LABEL"
hiddenLabel="false"
buttons="true"
filter="JComponentHelper::filterText"
asset_id="com_content"
/>I suppose false, and it will be look like the screenshot below:
What do you think?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31539.
@brianteeman the PR is RTC and I would like to merge it, but there is an open question from @Yiannistaos, can you please answer it? Thanks
The code is as intended
Ok!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-07 18:09:35 |
| Closed_By | ⇒ | drmenzelit | |
| Labels | |||
Thanks!
The class below is also added. Is that the intention?