? ? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
20 Nov 2020

Pull Request for Issue #30501 .

Summary of Changes

Limit the offset length to textlength

Testing Instructions

Create a test side with short and long articles and search for a word using php 8

Actual result BEFORE applying this Pull Request

search error 0 mb_strpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack)

Expected result AFTER applying this Pull Request

Get a search result

avatar HLeithner HLeithner - open - 20 Nov 2020
avatar HLeithner HLeithner - change - 20 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2020
Category Administration com_search
avatar bayareajenn bayareajenn - test_item - 20 Nov 2020 - Tested successfully
avatar bayareajenn
bayareajenn - comment - 20 Nov 2020

I have tested this item successfully on 5affcda

After applying patch, com_search works with PHP8. Thanks Harald.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31444.

avatar alikon alikon - test_item - 21 Nov 2020 - Tested successfully
avatar alikon
alikon - comment - 21 Nov 2020

I have tested this item successfully on 5affcda

php8 rc4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31444.

avatar alikon alikon - change - 21 Nov 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 21 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31444.

avatar richard67 richard67 - change - 21 Nov 2020
Labels Added: ? ? ?
avatar richard67 richard67 - change - 21 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-21 12:00:49
Closed_By richard67
Labels
avatar richard67 richard67 - close - 21 Nov 2020
avatar richard67 richard67 - merge - 21 Nov 2020
avatar richard67
richard67 - comment - 21 Nov 2020

Thanks!

Add a Comment

Login with GitHub to post a comment