Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31445] - Use proper string comparison function for tag aliases

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
20 Nov 2020

Pull Request for Tags Issue in PHP8

Summary of Changes

Changed arrow comparison function to use strcmp function

Testing Instructions

  1. Open Tags list view
  2. Open Search Tools

Actual result BEFORE applying this Pull Request

Deprecated: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in libraries/joomla/form/fields/aliastag.php on line 67

Expected result AFTER applying this Pull Request

No error

avatar HLeithner HLeithner - open - 20 Nov 2020
avatar HLeithner HLeithner - change - 20 Nov 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2020
Category ⇒ Libraries
avatar HLeithner HLeithner - change - 20 Nov 2020
Labels Added: ? ?
avatar Quy Quy - test_item - 20 Nov 2020 - Tested successfully
avatar Quy
Quy - comment - 20 Nov 2020

I have tested this item ✅ successfully on 69d1957

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

avatar bayareajenn bayareajenn - test_item - 21 Nov 2020 - Tested unsuccessfully
avatar bayareajenn
bayareajenn - comment - 21 Nov 2020

I have tested this item 🔴 unsuccessfully on 69d1957

I applied the patch and continued to have the same errors. :(

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

avatar alikon alikon - test_item - 21 Nov 2020 - Tested successfully
avatar alikon
alikon - comment - 21 Nov 2020

I have tested this item ✅ successfully on 69d1957

php8 rc4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

avatar richard67
richard67 - comment - 21 Nov 2020

I applied the patch and continued to have the same errors. :(

@bayareajenn Really? The Deprecated: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in libraries/joomla/form/fields/aliastag.php on line 67 error when opening the search tools in the tags list view? Have you checked if the patch has been applied correctly, i.e. the file shows the changes which you can see here on GitHub for that file?

avatar bayareajenn bayareajenn - test_item - 21 Nov 2020 - Tested successfully
avatar bayareajenn
bayareajenn - comment - 21 Nov 2020

I have tested this item ✅ successfully on 69d1957

My apologies, I tested this and then checked it against a different bug. Indeed this corrects the issue in tags. Thanks Harald.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

avatar richard67 richard67 - change - 21 Nov 2020
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 21 Nov 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31445.

avatar bembelimen bembelimen - change - 21 Nov 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-21 18:30:32
Closed_By ⇒ bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 21 Nov 2020
avatar bembelimen bembelimen - merge - 21 Nov 2020

Add a Comment

Login with GitHub to post a comment