[#31443] - [4.0] Don't display hidden menu items at all.
- Fixed in Code Base
- 21 Nov 2020
- Medium
- Build: 4.0-dev
- # 31443
- Diff
- Harmageddon:fix_hidden_menu_items
User tests: Successful: Unsuccessful:
Summary of Changes
If an item is set to hidden / not show, it doesn't make any sense to display an empty <li> item.
Testing Instructions
Because it is a backend module, this is a bit tricky.
Important: Don't activate the "Recovery mode" for the menu, because it seems to be bugged!
- At Menus - Manage, select "Administrator" and create a new menu.
- In this new administrator menu, create one basis menu item on the top level, and at least three menu items that are children to this basis menu item.
- For one of these child items, under "Link Type", set "Display in Menu: No".
- Go to the Home Dashboard.
- Click on "Add Module to the Dashboard".
- Type: "Administrator Dashboard Menu"
- Menu: select your previously created menu
- Enter a module title and save the module.
- Look at the newly created module.
Actual result BEFORE applying this Pull Request
At the place, where the hidden item would be, there is an empty <li></li> tag, which is displayed as empty space between two lines.
Expected result AFTER applying this Pull Request
Only the items that are not hidden are displayed.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
?
|
||
I have tested this item
On Code inspect
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31443.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31443.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31443.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-21 10:02:11 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks.
I have not tested this item.
I have no possibility to select the menu.
In Administrator Dashboard Menu I don't have the created menu items.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31443.
@adj9 How does your menu structure look? Do you have one parent menu item and several sub-menu items? Because this module only displays submenus, not entire menus. So the structure of "Test Menu" should look like this:
- Menu Item Lvl 1
- Subitem 1
- Subitem 2 (hidden)
- Subitem 3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31443.
I have tested this item✅ successfully on 873693d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31443.