[#31442] - Fix "Uncaught ValueError: Path cannot be empty ..." in com_joomlaupdate restore.php
- Fixed in Code Base
- 21 Nov 2020
- Medium
- Build: staging
- # 31442
- Diff
- richard67:staging-fix-joomlaupdate-restore-empty-path
User tests: Successful: Unsuccessful:
Pull Request for Issue #31308 .
Summary of Changes
Adds a check if the path is empty.
Testing Instructions
See issue #31308 .
To reproduce, update e.g. a 3.9.22 to 3.9.23 RC.
To test the fix of this PR, update e.g. a 3.9.22 to the update package built by Drone for this PR.
Verify that the update has run completely by checking the Joomla Update log file administrator/logs/joomla_update.php. The following logs should be there:
2020-11-20T18:39:21+00:00 INFO 192.168.98.1 update Update started by user Super User (342). Old version is 3.9.22.
2020-11-20T18:39:21+00:00 INFO 192.168.98.1 update Downloading update file from https://ci.joomla.org/artifacts/joomla/joomla-cms/staging/31442/downloads/37665/Joomla_3.9.23-rc+pr.31442-Release_Candidate-Update_Package.zip.
2020-11-20T18:39:22+00:00 INFO 192.168.98.1 update File Joomla_3.9.23-rc+pr.31442-Release_Candidate-Update_Package.zip downloaded.
2020-11-20T18:39:22+00:00 INFO 192.168.98.1 update Starting installation of new version.
2020-11-20T18:39:25+00:00 INFO 192.168.98.1 update Finalising installation.
2020-11-20T18:39:25+00:00 INFO 192.168.98.1 update Deleting removed files and folders.
2020-11-20T18:39:26+00:00 INFO 192.168.98.1 update Cleaning up after installation.
2020-11-20T18:39:26+00:00 INFO 192.168.98.1 update Update to version 3.9.23-rc+pr.31442 is complete.
Actual result BEFORE applying this Pull Request
See issue #31308 .
Expected result AFTER applying this Pull Request
No PHP error like described in issue #31308 .
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31442.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31442.
| Labels |
Added:
?
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-21 14:52:12 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
Thanks
@HLeithner As requested, I just applied (manually, by copy and paste) this patch to a 3.9.0-beta install on PHP 7.3.0beta3 (Just a docker container I had lying around) and then upgraded to Joomla 3.9.22 (in one step) and no issues to report.
However, I do note that the current Akeeba Kickstart 7.0.2 doesn't include this change, so tagging @nikosdion incase either he disagrees with the change for reasons only his experience will be able to shed light on, or, to aid Nik in adding this change to his kickstart.php code too.
thanks phil
I have tested this item✅ successfully on d158e60
php 8 rc4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31442.