[#31427] - [4.0] media manager fix inconsistent select
- Fixed in Code Base
- 21 Nov 2020
- Medium
- Build: 4.0-dev
- # 31427
- Diff
- dgrammatiko:4.0-dev_media_manager_dix_select
User tests: Successful: Unsuccessful:
Pull Request for Issue #30784 (comment)
Summary of Changes
Bug fix: The select box should respond to the same event as the thumb.
Testing Instructions
Edit an article and either try to set a fulltext/intro image or insert an image through the editor button.
Click around, selecting folder, image, clicking on the tick box, etc. The additional data should appear/disappear depending on the selected file (only on selected images). The next comment/gif might be helpful:
It seems you have to "click" the image and it is not enough to just "select the image" could that might be a different event?
Actual result BEFORE applying this Pull Request
Inconsistent behaviour
Expected result AFTER applying this Pull Request
All good
Documentation Changes Required
No bug fix
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change JavaScript |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31427.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31427.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-21 22:26:14 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on fa42716
Before applying the patch clicking the select tick box allows more than one image to be selected.
After applying the patch clicking the select box deselects any other selected image - consistent with clicking the image.
Needs npm i
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31427.