[#31361] - [4.0] Typo/Spelling BASIS
- Fixed in Code Base
- 6 Dec 2020
- Medium
- Build: 4.0-dev
- # 31361
- Diff
- brianteeman:basic
User tests: Successful: Unsuccessful:
Fixes obvious typing/spelling error BASIS should be BASIC
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End com_users |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
| Labels |
Added:
?
?
?
|
||
Noted that the ..._DESC are not used,
Indeed and, in this case, they are redundant with the label and therefore justifies their deletion.
Back to pending. Please delete them.
| Status | Ready to Commit | ⇒ | Pending |
Pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
| Labels |
Removed:
?
|
||
Guys these stings exists 11 years or more breaking all translations without any benefit doesn't makes sense to me.
If those strings existing 11 years and every attempt to change them was blocked because "breaking", it is time to make the step to finally correct the typo and havn't this discussion again in future.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
I have tested this item
It's working fine after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
I have tested this item
It's working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
I have tested this item
It's working fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.
@chmst Did you see @HLeithner 's comment above? #31361 (comment)
@HLeithner What shall we do with this?
I think doing it now for J4 is better than repeating this again and again.
But of course @HLeithner decides.
Personally I'd even move them to a com_users file as it's only used there and likely isn't used by 3rd parties.
I'm fine with that PR.
@brianteeman I don't see a reason why it should be in the joomla.ini file. It's a classic com_users menu parameter.
Maybe use "blame" to see if it once had been moved to there for some reason?
The strings are from 11 years ago .. this is befor my Joomla time and maybe there was only one language file?
There are other GLOBAL strings in that xml. If these BASIS are to be changed then they all should be changed. Personally this is all beyond the scope. The PR was just to fix a simple typo
Already did the blame thing. The strings were added back then by @infograf768 because the string apparently wasn't translated. One would have to see in the JC Archive if there was a specific reason for it.
There are other GLOBAL strings in that xml. If these BASIS are to be changed then they all should be changed. Personally this is all beyond the scope. The PR was just to fix a simple typo
The PR is fine for me as it is.
So please merge and we can all move on to more productive things ;)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-06 10:11:47 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
tks
thank you
I have tested this item✅ successfully on 06f7dc4
Noted that the ..._DESC are not used,
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31361.