[#31360] - [4.0] Login/Logout page image description [a11y]
- Fixed in Code Base
- 22 Dec 2020
- Medium
- Build: 4.0-dev
- # 31360
- Diff
- brianteeman:loginoout
User tests: Successful: Unsuccessful:
Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
This is very slightly different to the other similar PR as before this PR the alt text for the login image was hardcoded and the alt text for the logout page was an untranslated string. In addition the login and logout sections of the options have now been correctly placed into their own fieldsets
Background
To read why this change is very important see #31318
Testing Part 1
Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a Login form menu item and add an image for the login and logout
Testing Part 2
-
Image Description (Alt Text) = Empty
No Description = unchecked -
Image Description (Alt Text) = "some description"
No Description = unchecked -
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End com_users |
I am seeing a problem: in scenario 3, with Image Description empty and No Description checked, I get alt="2" for both login and logout image.
<img src="/joomla-cms-4/images/sampledata/parks/landscape/180px_ormiston_pound.jpg" class="com-users-logout__image thumbnail float-right logout-image" alt="2">
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.
@brianteeman you are right. Consistancy is key for a better usability. Thanks!!!
I have tested this item
What I found is,
- It gets failed at 3rd scenario i.e.
Image Description (Alt Text) = Empty
No Description = checked
it gives the result having an only src tag for the image & not the alt or alt=""
it gives the result having an only src tag for the image & not the alt or alt=""
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.
I have tested this item
I found problem: in scenario 3, with Image Description empty and No Description checked, I get result having an only src tag for the image & not the alt or alt=""
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.
| Labels |
Added:
Conflicting Files
?
?
|
||
I have fixed the conflicts and the reported bug. Please retest
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-22 08:27:43 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
Conflicting Files
|
||
Thanks
Thanks
@brianteeman I think this image is most of the time decorative, what do you think about making checkbox checked by default?