[#31359] - [4.0] tags menu items image alt [a11y]
- Fixed in Code Base
- 16 Apr 2021
- Medium
- Build: 4.0-dev
- # 31359
- brianteeman:tag1
Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
This is very slightly different to the other similar PR as before this PR there were no alt text at all not even empty ones
Background
To read why this change is very important see #31318
Testing Part 1
Testing is really easy. No npm, js or css involved.
Merge the pull request and then create one of each of the three types of tag menu items and add an image
List All Tags
Tagged Items & Compact Tagged Items
Testing Part 2
-
Image Description (Alt Text) = Empty
No Description = unchecked -
Image Description (Alt Text) = "some description"
No Description = unchecked -
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">
PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam
| Labels |
Added:
Conflicting Files
?
?
|
||
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings com_tags Front End |
Conflicts resolved
Looks like this doesnt appear on the issue tracker. It would be great if those on github could test it and we can get it merged as no one using patchtester will see it
@Quy @richard67 @chmst It would be great if you could test and merge this - apparently its missing from JIssues so no testers see it
| Status | New | ⇒ | Pending |
| Build | staging | ⇒ | 4.0-dev |
Tested successfully.
The PR works when the user sets values correct. But we have 4 cases
alt text | decorative only | Result
--------------------------------------------
not empty | checked | alt text is displayed (is this intended?)
not empty | not checked | alt text is displayed (correkt)
empty | checked | alt = "" (correct)
empty | not checked | no alt text at all - as much as i know this is not a11y
This is not about making all images have alt text or "".
Its all about making a conscious decision if an image has alt text or if it has "" which is correct for marking it as decorative
Its important that "empty | not checked " exists as thats the equivalent to not making a conscious decision and will now mean that an accessibility audit will identify the image as needs review to be given either an alt text or to be marked as decorative
empty | not checked | no alt text at all - as much as i know this is not a11y
ok, I forgot. Tested successfully.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31359.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-16 07:42:24 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
?
Removed: Conflicting Files ? |
||
Thanks all
Tested successfully. Listed as a discussion in issue tracker.