Feeling Lucky
?
?
[#31362] - [3.x] Typo / Spelling BASIS
- Closed
- 8 Nov 2020
- Medium
- Build: staging
- # 31362
- Diff
- brianteeman:basis
User tests: Successful: Unsuccessful:
Fixes obvious typing/spelling error BASIS should be BASIC
code review
This is a 3.x version of #31361 - it has to be done as separate PR because just merging this one into 4 will not fix everything in 4
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End com_users |
SharkyKZ
- comment
- 8 Nov 2020
Isn't removing strings a B/C break?
richard67
- comment
- 8 Nov 2020
Oh yes.
richard67
- comment
- 8 Nov 2020
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31362.
brianteeman
- comment
- 8 Nov 2020
Oops I forgot
Closing
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-08 10:34:55 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
?
|
||
richard67
- comment
- 8 Nov 2020
Would it make sense to do this fix for J3, only not deleting the old language strings but marking with a deprecation comment line above them, telling to use the new ones, and adding the new language strings (new constants)?
brianteeman
- comment
- 8 Nov 2020
Dont think its worth it
I have tested this item✅ successfully on 68edb4a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31362.