Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31315] - Added JLIB_INSTALLER_DISCOVER_INSTALL

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar ceford
ceford
5 Nov 2020

Pull Request for Issue #26299 . Note that me experience is with Joomla 4 and not Staging.

Summary of Changes

Added strings JLIB_INSTALLER_DISCOVER_INSTALL="Discover Install"
In admin and site lib_joomla.ini

I noticed that there places where strtoupper is missing: e.g - Text::('JLIB_INSTALLER' . $this->route), - leaving that as a separate issue but could fix if anyone would like to confirm - look in libraries/src/Installer/InstallerAdapter.php

Testing Instructions

See #26299
I do not know how to test this PR! I checked the code and I am fairly sure there is only one string missing from the set discover_install, install, update and uninstall.

Actual result BEFORE applying this Pull Request

Check the code: the strings are missing.

Expected result AFTER applying this Pull Request

Check the code: the strings are present.

Documentation Changes Required

None

avatar ceford ceford - open - 5 Nov 2020
avatar ceford ceford - change - 5 Nov 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2020
Category ⇒ Administration Language & Strings
avatar ceford
ceford - comment - 5 Nov 2020

I closed #31315 which was against 4.0-dev. Was that expected?

avatar ceford ceford - change - 5 Nov 2020
Title
…
Added JLIB_INSTALLER_DISCOVER_INSTALL
[4.0] Added JLIB_INSTALLER_DISCOVER_INSTALL
avatar ceford ceford - edited - 5 Nov 2020
avatar ceford ceford - change - 5 Nov 2020
Title
…
[4.0] Added JLIB_INSTALLER_DISCOVER_INSTALL
Added JLIB_INSTALLER_DISCOVER_INSTALL
avatar ceford ceford - edited - 5 Nov 2020
avatar SharkyKZ
SharkyKZ - comment - 5 Nov 2020

@ceford You can close that. Changes from staging should reach 4.0 eventually.

avatar SharkyKZ
SharkyKZ - comment - 5 Nov 2020

To test, download this package: plg_system_dummy.zip.
Drop its contents into plugins/system/dummy directory (have to create it first).
Go to Extensions -> Manage -> Discover.
Click Discover button if needed.
Check plg_system_dummy plugin and click Install.

Before patch you should get this message:

Warning
Extension JLIB_INSTALLER_discover_install: Custom install routine failure.

After patch:

Warning
Extension Discover Install: Custom install routine failure.

avatar SharkyKZ SharkyKZ - test_item - 5 Nov 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 5 Nov 2020

I have tested this item ✅ successfully on 22216c4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31315.

avatar Quy Quy - test_item - 5 Nov 2020 - Tested successfully
avatar Quy
Quy - comment - 5 Nov 2020

I have tested this item ✅ successfully on 22216c4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31315.

avatar Quy Quy - change - 5 Nov 2020
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 5 Nov 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31315.

avatar infograf768 infograf768 - change - 6 Nov 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-06 08:33:47
Closed_By ⇒ infograf768
Labels Added: ? ? ?
avatar infograf768 infograf768 - close - 6 Nov 2020
avatar infograf768 infograf768 - merge - 6 Nov 2020
avatar infograf768
infograf768 - comment - 6 Nov 2020

Tks.

Add a Comment

Login with GitHub to post a comment