[#31294] - Adds \ to all defines
- Closed
- 1 Nov 2020
- Medium
- Build: staging
- # 31294
- Diff
- N6REJ:defined_j3
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
using \define speeds things up.
several places were missing the \ This corrects that.
Testing Instructions
make sure J! still runs.
code review?
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Unit Tests Administration com_admin |
| Labels |
Added:
?
?
|
||
| Category | Repository Unit Tests Administration com_admin | ⇒ | Repository Unit Tests Administration com_admin com_associations com_categories com_config com_contact com_content com_fields |
Why are you deleting .github/SECURITY.md
No it wasn't and yes you are.
You are also deleting
| Category | Repository Unit Tests Administration com_admin com_associations com_categories com_config com_contact com_content com_fields | ⇒ | Repository Unit Tests Administration com_admin com_config com_contact com_content com_fields com_installer com_joomlaupdate com_media com_menus com_modules com_search com_tags com_templates |
And adding an unrelated svg
Every file in the fof folder that you have changed need to have their copyright updated if it does not already do so
* @note This file has been modified by the Joomla! Project and no longer reflects the original work of its author.
@brianteeman might wanna check staging before you blame me for everything.. I didn't add anything
after reviewing several files I"m closing this as it's changing things that I didn't change.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-01 22:31:28 |
| Closed_By | ⇒ | N6REJ |
git doesnt lie
your full of crap @brianteeman #30778 is the cause of all that.. check the damn logs!!
you owe me an apology
a PR that touches over 2700 files is impossible to test