User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Repository Administration |
Labels |
Added:
?
|
Category | Repository Administration | ⇒ | Repository |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-01 22:58:02 |
Closed_By | ⇒ | zero-24 |
the title of this pr and commit has no relevance to the changes
go away @brianteeman you clearly can't read logs
Please do not attack each other personally here. This PR here fixed an whitespace issue and i might should have choosen an better commit message, right. When there are personal differences please clear them offline and not at the tracker. Thanks!
@zero-24 nothing personal. Was just pointing out that the commit message has no relevance to a whitespace change. The git commit log has value and should have relevant messages. However it is clear from @N6REJ comments and subsequent PR that he was expecting this PR to do more than a simple white space change
@zero-24 ok i'm totally confused... when checking my "git log" for things that changed from todays pull from staging it blamed #30778 for 3 files being deleted and 1 file being added. When I told git to revert that it happily did so but I didn't realize it wouldn't "add" those files back to git which is why they didn't show up the first time.
Now when I check the log it shows they are infact back now.
It really is much easier if you always create branches from joomla-cms and not from a local fork and that you always create a new branch for every pr
It really is much easier if you always create branches from joomla-cms and not from a local fork and that you always create a new branch for every pr
thats my general practice..
Something wrong with that method?
for updating/syncing the process is almost identical
I use git in phpstorm mostly.
Mergeing that whitespace only fix in the readme now by review thanks @N6REJ