Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31293] - [4.0] Adds \ to all namespaced defines

? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
1 Nov 2020

Pull Request for Issue # .

Summary of Changes

using \define speeds things up.
several places were missing the \ This corrects that.

Testing Instructions

make sure J! still runs.
code review?

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar N6REJ N6REJ - open - 1 Nov 2020
avatar N6REJ N6REJ - change - 1 Nov 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2020
Category ⇒ Administration com_admin com_ajax com_associations
avatar N6REJ N6REJ - change - 1 Nov 2020
Title
…
Adds \ to all defines
[4.0] Adds \ to all defines
avatar N6REJ N6REJ - edited - 1 Nov 2020
avatar N6REJ N6REJ - change - 1 Nov 2020
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 1 Nov 2020

This only makes a difference in namespaced files.

avatar brianteeman
brianteeman - comment - 1 Nov 2020

Any PR that touches over a 1000 files is impossible to test

avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2020
Category Administration com_admin com_ajax com_associations ⇒ Administration com_admin com_associations com_banners com_categories com_config
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2020
Category Administration com_admin com_associations com_banners com_categories com_config ⇒ Administration com_admin com_associations com_banners com_categories com_config com_contact com_content com_fields com_finder
avatar richard67
richard67 - comment - 2 Nov 2020

@N6REJ It seems when you have reverted some of the changes for the non-namespaced files, you have also removed indentation, see e.g. here:

https://github.com/joomla/joomla-cms/pull/31293/files#diff-a225d694617c9bd244487ecd686306d39cde6f74cc6bd5f2203fb64735db62f6R37

Drone reports a bunch of them here: https://ci.joomla.org/joomla/joomla-cms/37307/1/6

avatar N6REJ
N6REJ - comment - 2 Nov 2020

looks like we got everything.

avatar N6REJ N6REJ - change - 3 Nov 2020
Title
…
[4.0] Adds \ to all defines
[4.0] Adds \ to all namespaced defines
avatar N6REJ N6REJ - edited - 3 Nov 2020
avatar jwaisner jwaisner - test_item - 3 Nov 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 3 Nov 2020

I have tested this item ✅ successfully on 60f8acf

Tested new Joomla installation. Navigated to all possible portions of the website. Added and removed content as well as tested caching and no issues found from a functionality standpoint.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31293.

avatar Quy Quy - test_item - 5 Nov 2020 - Tested successfully
avatar Quy
Quy - comment - 5 Nov 2020

I have tested this item ✅ successfully on 60f8acf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31293.

avatar Quy Quy - change - 5 Nov 2020
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 5 Nov 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31293.

avatar N6REJ N6REJ - change - 8 Nov 2020
Labels Added: ?
avatar HLeithner HLeithner - change - 8 Nov 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-08 17:34:52
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 8 Nov 2020
avatar HLeithner HLeithner - merge - 8 Nov 2020
avatar HLeithner
HLeithner - comment - 8 Nov 2020

Thanks

Add a Comment

Login with GitHub to post a comment