Feeling Lucky
?
?
[#31274] - [3] - same DDL for table #__contact_details
- Fixed in Code Base
- 6 Nov 2020
- Medium
- Build: staging
- # 31274
- Diff
- alikon:patch-117
User tests: Successful: Unsuccessful:
Pull Request for Issue #31271
Summary of Changes
Table #__contact_details the same from install #__contact_details
Testing Instructions
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact |
viocassel
- comment
- 5 Nov 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31274.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 5 Nov 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31274.
HLeithner
- comment
- 6 Nov 2020
Whats the reason for changing char to varchar for the language column? My understanding is that char always reserves 7 char (I expect bytes) and varchar in could be 5 to 28 bytes which have a performance penalty for utf8 and variable length.
Maybe my information are wrong or outdated ymmv.
alikon
- comment
- 6 Nov 2020
it come from 2428786#diff-be47cba58b55d509f8fe51ce691d0aa15c0272086fdbb6ea6a319ced93c6cc41R284
#14113 some kind of 4 y ago
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-06 16:32:19 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
HLeithner
- comment
- 6 Nov 2020
thanks
I have tested this item✅ successfully on 066f6a6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31274.