Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31273] - [4.0] Fix saving items without creation date

? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
30 Oct 2020

Fixes #31046.

Summary of Changes

Fixes saving content without creation date.

Testing Instructions

Edit an article/contact/banner/category/newsfeed/custom field/custom field group/smart search filter.
Remove value from Created Date field.
Save.

Actual result BEFORE applying this Pull Request

An error like this:

Save failed with the following error: Incorrect datetime value: '' for column 'created_time' at row 1

Expected result AFTER applying this Pull Request

Item saved and Created Date field populated with current date.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 30 Oct 2020
avatar SharkyKZ SharkyKZ - change - 30 Oct 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2020
Category ⇒ Administration com_banners com_fields com_finder com_newsfeeds Libraries
avatar gostn gostn - test_item - 30 Oct 2020 - Tested unsuccessfully
avatar gostn
gostn - comment - 30 Oct 2020

I have tested this item ? unsuccessfully on 64e3d46

Fail on Contacts.

Successfully test on:

  • Article
  • Articles: categories
  • Articles: custom field
  • Articles: custom field group
  • Banners
  • Banners: categories
  • Contacts: categories
  • News Feeds: feeds
  • News Feeds: category
  • Smart search: filters
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31273.
avatar SharkyKZ SharkyKZ - change - 30 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2020
Category Administration com_banners com_fields com_finder com_newsfeeds Libraries ⇒ Administration com_banners com_contact com_fields com_finder com_newsfeeds Libraries
avatar SharkyKZ
SharkyKZ - comment - 30 Oct 2020

Please test with contacts again.

avatar richard67
richard67 - comment - 30 Oct 2020

@SharkyKZ It seems Drone is failing with composer install. Can if be that your composer.lock is modified somehow our out of date? If not, ping me, then we have to check if these is something wrong with the testing environment.

Update 2020-11-01: Meanwhile it's clear that it was a problem with testing environment. Re-started drone to see if it passes now.

avatar gostn gostn - test_item - 30 Oct 2020 - Tested successfully
avatar gostn
gostn - comment - 30 Oct 2020

I have tested this item ✅ successfully on cfd2780

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31273.

avatar toivo toivo - test_item - 30 Oct 2020 - Tested successfully
avatar toivo
toivo - comment - 30 Oct 2020

I have tested this item ✅ successfully on cfd2780

Tested successfullky in Beta6-dev of 30 October.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31273.

avatar richard67 richard67 - change - 1 Nov 2020
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 1 Nov 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31273.

avatar laoneo laoneo - close - 2 Nov 2020
avatar laoneo laoneo - merge - 2 Nov 2020
avatar laoneo laoneo - change - 2 Nov 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-11-02 07:23:04
Closed_By ⇒ laoneo
Labels Added: ?
avatar laoneo
laoneo - comment - 2 Nov 2020

Thanks

Add a Comment

Login with GitHub to post a comment