Feeling Lucky
?
?
[#31245] - Correct return type and add comment
- Fixed in Code Base
- 29 Oct 2020
- Medium
- Build: staging
- # 31245
- Diff
- SharkyKZ:j3/docbclock/jhtml-image
User tests: Successful: Unsuccessful:
Summary of Changes
Corrects return type for Joomla\CMS\HTML\HTMLHelper::image().
Testing Instructions
Review.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
chmst
- comment
- 27 Oct 2020
Why then not return null; instead of return $file on line 587?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31245.
Quy
- comment
- 27 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31245.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 27 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31245.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-29 11:52:29 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 29 Oct 2020
Thanks!
I have tested this item✅ successfully on 0d559a6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31245.