Feeling Lucky
?
?
[#31246] - Use ZipArchive in JArchiveZip
- Fixed in Code Base
- 14 Nov 2020
- Medium
- Build: staging
- # 31246
- Diff
- SharkyKZ:j3/php8/zip
User tests: Successful: Unsuccessful:
Summary of Changes
zip_* functions are deprecated on PHP 8. Use ZipArchive instead.
Testing Instructions
Test that extracting zip archive using JArchiveZip still works. E.g. use this code:
$zip = new JArchiveZip;
$zip->extract($file, $destination);
Where $file is path to zip archive and $destination is destination directory.
Expected result AFTER applying this Pull Request
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
SharkyKZ
- comment
- 7 Nov 2020
Already done.
alikon
- comment
- 7 Nov 2020
what i'm missing ?
https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/archive/src/Zip.php#L276-L315
is full of zip_*
HLeithner
- comment
- 14 Nov 2020
I tested the Zip Archive in our framework (which uses the same code) successfully.
Thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-14 18:02:05 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
you should do the same fix on https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/archive/src/Zip.php too