[#31202] - [4.0] "Authentification" correction
- Fixed in Code Base
- 8 Nov 2020
- Medium
- Build: 4.0-dev
- # 31202
- Diff
- particthistle:4.0-dev
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Correction of language and hint positioning for two factor authentication field on login page.
Pull Request does not have a related issue - I identified issue while checking through translations, then found an issue where it appears in the site.
Summary of Changes
- Correct "Authentification" to "Authentication" in COM_LOGIN_TWOFACTOR string (Authentification is valid, but not proper en_GB)
- On viewing where the string was being used, I then found the layout is incorrect, so have fixed that also.
- scss update to create new class for .form-control-hint to fix the layout.
Testing Instructions
- In Joomla 4, enable one of the two factor authentication plugins
- Log out
- On the log in screen you'll now see the Secret Key box, with the spelling issue and the incorrect formatting of the hint that uses COM_LOGIN_TWOFACTOR string.
- Apply PR
- Log out again and check that the Log in screen now has the corrected en_GB spelling as well as better formatting per the AFTER result below.
Actual result BEFORE applying this Pull Request
- Spelling error still visible - COM_LOGIN_TWOFACTOR string will display as "For Two-Factor Authentification" for en_GB
- Hint for Secret Key is supposed to be positioned on the right, but due to double span the text-right class fails to do so.
Expected result AFTER applying this Pull Request
- COM_LOGIN_TWOFACTOR string will now show as "For Two-Factor Authentication"
- Hint for Secret Key will now be displayed above the field, to the right of the field.
Documentation Changes Required
No. en_GB translation will be updated, but will most likely have been correctly translated into other languages previously. I just spotted the issue when translating en_US.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules Templates (admin) NPM Change |
I've checked I got the SCSS change correct this time by applying the PR package to my test site. Result was as expected in the AFTER result, so I look forward to seeing successful tests shortly.
@particthistle SCSS code style check fails in Drone, error log see here: https://ci.joomla.org/joomla/joomla-cms/36866/1/22
| Labels |
Added:
?
NPM Resource Changed
?
|
||
@particthistle Now drone says in the npm clone step:
CSS file copied/minified: /********/src/build/media_source/system/css/fields/calendar.css
--
Error: Invalid CSS after "}": expected "}", was ""
on line 251 of administrator/templates/atum/scss/blocks/_login.scss
from line 43 of administrator/templates/atum/scss/template.scss
>> }
The changes on GitHub for that file show up as:
Can it be that there is missing a closing curly bracket before the .form-control-hint?
Beside that, check code style. In scss we use 2 spaces for each level of indentation and no tabs.
If that helps, adjust your editor so it shows tabs and spaces, then you can see what is used.
| Category | Administration Language & Strings Modules Templates (admin) NPM Change | ⇒ | Repository Administration Language & Strings Modules Templates (admin) NPM Change |
I have tested this item
Tip: use a different browser to see Login form - no need to logout.
Needs npm ci
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31202.
| Labels |
Added:
?
|
||
| Category | Administration Language & Strings Modules Templates (admin) NPM Change Repository | ⇒ | Administration Language & Strings Modules Templates (admin) NPM Change |
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Removed:
?
|
||
I have tested this item
Seems OK but I did not see the Web Authentication bar with either plugin.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31202.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31202.
Using localhost - and access is via http.
More than desired it is intentional as webauthn will only work on https
Thanks for the tips! I did not have https enabled on localhost. I have now done that and see the Web Authentication button. Next job for me: find out what it does!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31202.
Next job for me: find out what it does!
Making your site more secure :-D You can check here as a starting point: https://en.m.wikipedia.org/wiki/WebAuthn
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31202.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-08 09:07:33 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
LGTM