[#31201] - [4.0] Don't ship .es6 files
- Fixed in Code Base
- 2 Nov 2020
- Medium
- Build: 4.0-dev
- # 31201
- Diff
- SharkyKZ:j4/build/es6
User tests: Successful: Unsuccessful:
Closes #29092.
Summary of Changes
Excludes .es6 files from being copied to media directory.
Testing Instructions
Download and install this package https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/31201/downloads/36975/Joomla_4.0.0-beta5-dev+pr.31201-Development-Full_Package.zip.
Check that JS functionality still works (e.g. messages, modals, form validation).
Check if media/system/js/core.es6 directory exists.
Expected result
media/system/js/core.es6 directory doesn't exist and JS functionality works properly.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
It's available now. Added the link in testing instructions.
Can we exclude the "*.es6" folder too?
@HLeithner should be OK now.
thx
I have tested this item
Performed a fresh install with the new package
media/system/js/core.es6directory doesn't exist and JS functionality works properly.- no errors discovered while performing some random checks of javascript functions, which is expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31201.
I have tested this item
No errors after fresh install on provided package. Checked various functionalities with no errors as well.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31201.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31201.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-02 08:10:59 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
@HLeithner @wilsonge As these .es6 and scss files and the es6 folder will not be included into the next Beta (or RC?) build, it would need to include them into the list of files and folders to be deleted in script.php so they are deleted when updating previous 4 Beta versions, or not?
This is part of the release process.
Yes, I know .. it was forgotten when doing Beta 4 (Beta 5 was ok then), so I thought I set a reminder.
@SharkyKZ, the Install package mentioned in the test instructions is not available yet.