[#31146] - [4.0] Cleanup jstools
- Fixed in Code Base
- 19 Oct 2020
- Medium
- Build: 4.0-dev
- # 31146
- Diff
- dgrammatiko:4.0-dev-cleanup-jstools
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Move the build.js file into the build folder
- Move the . eslintrc file into the build folder
- Move the .stylelintrc.json file into the build folder
- Remove redundant drone-package.json (this might be wrong, let's see if things break bad)
- Fix couple of styling issues in Media Manager (Oops, blame said that I was responsible)
- Make sure that Drone is running the same commands for linting js and scss
Testing Instructions
If Drone is ok that will be all the tests needed here (there is no real functionality changed here except changing some paths)
Actual result BEFORE applying this Pull Request
Eslint and Stylelint are using different commands in the dev CLI and Drone. Although things seem to be green in reality they're not
Expected result AFTER applying this Pull Request
Everything is Green
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Unit Tests Administration com_media NPM Change Repository JavaScript |
| Labels |
Added:
NPM Resource Changed
?
?
|
||
@richard67 is there some special ritual for the drone.yml ?
Yes if you modify the drone.yml we have to sign it, I started it by hand.
about the *.css linter thing, we have some .es files (introduced by me...)
about the *.css linter thing, we have some .es files (introduced by me...)
I'm not changing any of the logic here, just moving the configuration files from the root folder to the build folder and making sure that both the CLI and Drone are executing the same commands
| Labels |
Added:
?
Removed: ? |
||
Ok then I missunderstood the changes... I signed your done.yml.
Thanks
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-19 09:16:16 |
| Closed_By | ⇒ | HLeithner |
@richard67 is there some special ritual for the drone.yml ?
