Feeling Lucky
NPM Resource Changed
?
?
[#31145] - [4.0] Backend: use default bootstrap tabs styling for .nav-tabs
- Fixed in Code Base
- 19 Oct 2020
- Medium
- Build: 4.0-dev
- # 31145
- Diff
- Fedik:style-tabs
User tests: Successful: Unsuccessful:
Summary of Changes
Since of last backend restyling, all tabs was replaced to joomla-tab.
However in a css still left an old style for .nav-tabs, and it looks bad.
Testing Instructions
Apply patch, run node build.js --compile-css
Edit administrator/templates/atum/index.php, before <jdoc:include type="message" /> add:
<div class="bg-white p-3">
<ul class="nav nav-tabs">
<li class="nav-item">
<a class="nav-link active" href="#">Active</a>
</li>
<li class="nav-item">
<a class="nav-link" href="#">Link</a>
</li>
<li class="nav-item">
<a class="nav-link" href="#">Link</a>
</li>
<li class="nav-item">
<a class="nav-link disabled" href="#">Disabled</a>
</li>
</ul>
</div>then open any backend page.
Actual result BEFORE applying this Pull Request
There an old tabs
Expected result AFTER applying this Pull Request
There a default bootstrap tabs
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
jwaisner
- comment
- 19 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31145.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 19 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31145.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-19 21:10:13 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 19 Oct 2020
Thanks!
I have tested this item✅ successfully on 8ac6d9b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31145.