[#31120] - Fix workflow/stage unpublish/trash/deletion prevention
- Fixed in Code Base
- 23 Oct 2022
- Medium
- Build: 4.0-dev
- # 31120
- Diff
- bembelimen:4.0/workflow/deletion
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
When trying to unpublish/trash/delete a workflow/stage currently the joomla plugins has a check implemented to prevent the status change if there are items (articles) assigned.
This checks are broken and should be fixed with this PR
Testing Instructions
Build different scenarios like 2 workflows one assigned to articles, one not. Try to unpublish/trash both workflows. If successful switch places (first workflow has no items assigned).
Same for stages.
Also try to delete assigned workflows.
Actual result BEFORE applying this Pull Request
Sometimes you can delete workflow/stages with items assigned. Sometimes you can't trash workflows although no items are assigned.
Expected result AFTER applying this Pull Request
Not possible anymore to trash workflows/stages when articles are assigned.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
?
Removed: ? |
||
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Title |
|
||||||
| Labels |
Added:
PR-4.3-dev
?
Removed: ? ? |
||
@bembelimen should we close this because of the great success with this change :-)
| Labels |
Added:
Maintainers Checked
|
||
| Category | Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
I have tested this item red_circle unsuccessfully on 753a0a6Inconsistent behavior:
If you mark a stage/workflow that is not in use and not default and one that is default and want to delete both, he deletes one stage If you mark a stage/workflow that is not in use and not default and one that is in use and want to delete both, it does not delete any stage If you mark a stage/workflow that is not in use and not default and one that is default AND is in use and wants to delete both, he deletes one stage
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31120.
So updated the PR, it should only unpublish/trash/delete anything of all of the selected items have no assignments.
Please test again.
| Title |
|
||||||
| Labels |
Added:
Language Change
|
||
Line 559
if (!$this->_canDeleteStage($pk)) {
has to be changed with _workflowNotUsed
Thx
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31120.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31120.
My bad. It should be "in a published"
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31120.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-23 10:53:10 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item? unsuccessfully on 753a0a6
Inconsistent behavior:
If you mark a stage/workflow that is not in use and not default and one that is default and want to delete both, he deletes one stage
If you mark a stage/workflow that is not in use and not default and one that is in use and want to delete both, it does not delete any stage
If you mark a stage/workflow that is not in use and not default and one that is default AND is in use and wants to delete both, he deletes one stage
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31120.