Feeling Lucky
?
?
[#31121] - [4.0] Fix undefined error when invalid redis cache host
- Fixed in Code Base
- 21 Oct 2020
- Medium
- Build: 4.0-dev
- # 31121
- Diff
- joomla:feature/invalid-var
- Pending continuous-integration/drone/push Build is running Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30378 (partial) .
Summary of Changes
Fixes the $connection variable being undefined if an exception is thrown connecting to the redis server for caching
Testing Instructions
Setup redis as a cache provider but don't point to a valid host
Actual result BEFORE applying this Pull Request
A whole host of errors (see the linked issue)
Expected result AFTER applying this Pull Request
Many pconnect warnings still - but no undefined variable warnings
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
alikon
- comment
- 21 Oct 2020
i still see Notices
Undefined variable: connection in /shared/httpd/j4/joomla/libraries/src/Cache/Storage/RedisStorage.php on line 108
sorry patched wrong branch
alikon
- comment
- 21 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31121.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 21 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31121.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-21 18:47:17 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 21 Oct 2020
Thanks!
I have tested this item✅ successfully on 7a2b0ee
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31121.