? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
17 Oct 2020

Summary of Changes

The workflow onWorkflowBeforeTransition uses the "new" event handling method (setting some internal parameters), but the two plugins still only return false;. So this PR takes care of it.

Testing Instructions

It's rather hard to test, because there is no plugin which uses this function in the core. What you need is a plugin listening to onContentBeforeChangeState and returning false.

Actual result BEFORE applying this Pull Request

Transition is still executed.

Expected result AFTER applying this Pull Request

Transition is stopped-

avatar bembelimen bembelimen - open - 17 Oct 2020
avatar bembelimen bembelimen - change - 17 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category Front End Plugins
avatar wilsonge wilsonge - change - 17 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-17 01:50:49
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 17 Oct 2020
avatar wilsonge wilsonge - merge - 17 Oct 2020
avatar wilsonge
wilsonge - comment - 17 Oct 2020

Thanks!

Add a Comment

Login with GitHub to post a comment