[#31057] - [4] Remove unused array - Array is only updated, but never queried
- Fixed in Code Base
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 31057
- Diff
- PhilETaylor:removeunusedarray
User tests: Successful: Unsuccessful:
Summary of Changes
Remove unused array - Array is only updated, but never queried, thus its just taking up time and memory and can safely be removed
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
well it certainly does exist :-)
https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/sampledata/testing/testing.php
@ChristineWk The file belongs to testing sample data. Testing sample data is not shipped with installation packages, in opposite to the other kinds of sample data. Testing sample data is only available on a git clone.
@PhilETaylor We don't ship the testing sample data with installation packages. I guess @ChristineWk tested on such an environment where ain installation package has bee used once, and not a git clone.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.
I have tested this item
Saw the code change OK.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 17:23:40 |
| Closed_By | ⇒ | richard67 | |
| Labels | |||
Thanks!
Got response: The file marked for modification does not exist: plugins/sampledata/testing/testing.php
4.0.0-beta5dev (9th October,2020)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.