? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
11 Oct 2020

Summary of Changes

Remove unused array - Array is only updated, but never queried, thus its just taking up time and memory and can safely be removed

Testing Instructions

Code review

avatar PhilETaylor PhilETaylor - open - 11 Oct 2020
avatar PhilETaylor PhilETaylor - change - 11 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2020
Category Front End Plugins
avatar ChristineWk
ChristineWk - comment - 11 Oct 2020

Got response: The file marked for modification does not exist: plugins/sampledata/testing/testing.php
4.0.0-beta5dev (9th October,2020)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2020
avatar richard67
richard67 - comment - 11 Oct 2020

@ChristineWk The file belongs to testing sample data. Testing sample data is not shipped with installation packages, in opposite to the other kinds of sample data. Testing sample data is only available on a git clone.

avatar richard67
richard67 - comment - 11 Oct 2020

@PhilETaylor We don't ship the testing sample data with installation packages. I guess @ChristineWk tested on such an environment where ain installation package has bee used once, and not a git clone.

avatar Quy Quy - test_item - 12 Oct 2020 - Tested successfully
avatar Quy
Quy - comment - 12 Oct 2020

I have tested this item successfully on 7c77e1b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.

avatar ceford ceford - test_item - 14 Oct 2020 - Tested successfully
avatar ceford
ceford - comment - 14 Oct 2020

I have tested this item successfully on 7c77e1b

Saw the code change OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.

avatar richard67 richard67 - change - 14 Oct 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 14 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31057.

avatar richard67 richard67 - change - 14 Oct 2020
Labels Added: ? ?
avatar richard67 richard67 - change - 15 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-15 17:23:40
Closed_By richard67
Labels
avatar richard67 richard67 - close - 15 Oct 2020
avatar richard67 richard67 - merge - 15 Oct 2020
avatar richard67
richard67 - comment - 15 Oct 2020

Thanks!

Add a Comment

Login with GitHub to post a comment