Feeling Lucky
Conflicting Files
?
[#31056] - [4] Expression can be safely replaced
- Closed
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 31056
- Diff
- PhilETaylor:expressionsimplifiy
User tests: Successful: Unsuccessful:
Summary of Changes
Expression can be safely replaced and simplified and was Code Smell as reported by phpStorm.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
ceford
- comment
- 14 Oct 2020
Not sure about this. My source was slightly different from the diff
-
$mode = $mode === 1 ? true : false;
my source
$mode = $mode === 1;
Although the result was as expected. I am set up for testing with the nightly build.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31056.
ceford
- comment
- 14 Oct 2020
I have tested this item
Changed to my new Test setup - doing it right this time - saw code change OK.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31056.
Quy
- comment
- 14 Oct 2020
Please fix conflicts. Thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 09:03:51 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
Conflicting Files
?
|
||
I have tested this item✅ successfully on c5fe431
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31056.