Conflicting Files ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
11 Oct 2020

Summary of Changes

Expression can be safely replaced and simplified and was Code Smell as reported by phpStorm.

Testing Instructions

Code review

avatar PhilETaylor PhilETaylor - open - 11 Oct 2020
avatar PhilETaylor PhilETaylor - change - 11 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2020
Category Front End Plugins
avatar PhilETaylor PhilETaylor - change - 11 Oct 2020
Title
Expression can be safely replaced
[4] Expression can be safely replaced
avatar PhilETaylor PhilETaylor - edited - 11 Oct 2020
avatar ChristineWk ChristineWk - test_item - 11 Oct 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 11 Oct 2020

I have tested this item successfully on c5fe431


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31056.

avatar ceford
ceford - comment - 14 Oct 2020

Not sure about this. My source was slightly different from the diff

  •   $mode = $mode === 1 ? true : false;
    

my source
$mode = $mode === 1;
Although the result was as expected. I am set up for testing with the nightly build.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31056.

avatar ceford ceford - test_item - 14 Oct 2020 - Tested successfully
avatar ceford
ceford - comment - 14 Oct 2020

I have tested this item successfully on c5fe431

Changed to my new Test setup - doing it right this time - saw code change OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31056.

avatar Quy
Quy - comment - 14 Oct 2020

Please fix conflicts. Thanks.

avatar PhilETaylor
PhilETaylor - comment - 15 Oct 2020

It looks like one of my other PRs already merged already addressed this change

#31071

avatar PhilETaylor PhilETaylor - change - 15 Oct 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-10-15 09:03:51
Closed_By PhilETaylor
Labels Added: Conflicting Files ?
avatar PhilETaylor PhilETaylor - close - 15 Oct 2020

Add a Comment

Login with GitHub to post a comment