Feeling Lucky
?
[#31058] - [4] Cleanup of switch statements to remove code smell & adhere to code style guidelines
- Fixed in Code Base
- 16 Oct 2020
- Medium
- Build: 4.0-dev
- # 31058
- Diff
- PhilETaylor:switchcleanup
User tests: Successful: Unsuccessful:
Summary of Changes
Cleanup of switch statements to remove code smell & adhere to code style guidelines - mostly reported by inspection in phpStorm
Removes spaces before :
Removes redundant cases that are already caught by default, you don't need case statements on the same block as the default.
default commonly found as last block, not first, refactored one place to make it last
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_installer Front End com_ajax com_contact com_content com_tags com_users Modules Plugins |
| Title |
|
||||||
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 13 Oct 2020
Committed suggestions
ChristineWk
- comment
- 13 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31058.
| Category | Administration com_finder com_installer Front End com_ajax com_contact com_content com_tags com_users Modules Plugins | ⇒ | Repository Administration com_associations com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_login com_menus com_templates com_users Language & Strings Templates (admin) NPM Change |
PhilETaylor
- comment
- 15 Oct 2020
well I screwed this PR somehow :(
| Labels |
Added:
?
NPM Resource Changed
|
||
| Category | Administration com_finder com_installer com_contact com_content com_users Repository com_associations com_fields com_joomlaupdate com_login com_menus com_templates Language & Strings Templates (admin) NPM Change | ⇒ | Administration com_finder com_installer Front End com_ajax com_contact com_content com_tags com_users Modules Plugins |
PhilETaylor
- comment
- 15 Oct 2020
Force pushing to fix rebase issue.. one moment
| Labels |
Removed:
?
NPM Resource Changed
|
||
PhilETaylor
- comment
- 15 Oct 2020
ok merge complete - no conflicts this time - ready for testing again
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-16 11:04:00 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on ecb33bc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31058.