[#31040] - [4.0] Non-empty, non-matching searches shouldn't return anything
- Fixed in Code Base
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 31040
- Diff
- Hackwar:j4finder_emptysearch
User tests: Successful: Unsuccessful:
Summary of Changes
This fixes #30967. When empty searches are allowed and the search is non-empty, but not matching, then it shouldn't return any results.
Testing Instructions
- After installation, insert sample data of choice.
- Edit global options of Smart Search and set "Allow Empty Search" to "Yes".
- Go to the frontend and open Smart Search for example by accessing index.php?option=com_finder&view=search.
- Search for something that definitely is not on the site, like "cockadoodle".
Actual result BEFORE applying this Pull Request
Returns all entries in your index.
Expected result AFTER applying this Pull Request
Returns an empty result.
Documentation Changes Required
none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
I have tested this item
Thanks for easy to understand test instructions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31040.
Silly question maybe, but what is the use of the Allow Empty Search parameter (allow_empty_query)
You can display your index content right away. For example, if you fill your com_contact with vendors of your product, you could create a menu item that only displays such contacts. So in the frontend you can now always display a list of entries and filter that further via additional taxonomies. I've got several instances, where my customers use this.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31040.
| Labels |
Added:
?
?
|
||
I have tested this item ✅ successfully on 39c168f
System Information
php: Linux orion 5.4.0-48-generic #52-Ubuntu SMP Thu Sep 10 10:58:49 UTC 2020 x86_64
dbserver: mysql
dbversion: 8.0.21-0ubuntu0.20.04.4
dbcollation: utf8mb4_0900_ai_ci
dbconnectioncollation: utf8mb4_0900_ai_ci
dbconnectionencryption:
dbconnencryptsupported: true
phpversion: 7.4.3
server: Apache/2.4.41 (Ubuntu)
sapi_name: apache2handler
version: Joomla! 4.0.0-beta4 Beta [ Mañana ] 15-September-2020 13:46 GMT
useragent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31040.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 16:24:48 |
| Closed_By | ⇒ | richard67 | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on 39c168f
Without patch: 18 results. With patch: 0 results.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31040.