[#31041] - [4.0] Categories need to have a route to be indexed
- Fixed in Code Base
- 17 Oct 2020
- Medium
- Build: 4.0-dev
- # 31041
- Diff
- Hackwar:patch-19
User tests: Successful: Unsuccessful:
Pull Request for Issue #30968.
Summary of Changes
When indexing categories, we need to have a route to those categories. If there is no (valid) route, we can't generate a URL to the search results source. Simply falling back to the RouteHelper of com_content is definitely wrong.
Testing Instructions
- After installation insert the Blog Sampledata.
- Go to Smart Search and click "indexing".
- Search in the frontend for "Uncategorised" by visiting
index.php?option=com_finder&view=search.
Actual result BEFORE applying this Pull Request
You will see an entry with ID 7. Clicking on the link will give a 404. If you look in the database, the category with ID 7 belongs to the component com_users.
Expected result AFTER applying this Pull Request
After clearing the index and indexing again, there is no result with ID 7 anymore.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I found this a bit too confusing to decide if my test passed. I already had a multi-lingual site with some test articles, categories, contacts and so on. I installed the Test Data and cleared and reindexed without the patch. That gave me five search results. None gave 404 links but all had the title Uncategised, which was not helpful:
- Animals article (uncategorised)
- Home page
- Uncategorised contact list
- Uncategorised Newsfeeds - none
- Home page
With the patch and the index cleared and reindexed I got three results:
- Animals article (uncategorised)
- Uncategorised contact list
- Uncategorised Newsfeeds - none
That looks better. But is it a pass?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31041.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31041.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31041.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31041.
| Labels |
Added:
?
?
|
||
Tested successfully
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-17 10:55:41 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Thanks!
This won't work with 3rd party extensions. Maybe use
Joomla\CMS\Helper\RouteHelper?