? ? ? Success

User tests: Successful: Unsuccessful:

avatar ceford
ceford
10 Oct 2020

Pull Request for Issue # .

Summary of Changes

Remove Latest Version Check Help screen from the Joomla! Help page in Joomla 4.

Testing Instructions

In Joomla 3 or Joomla 4 go to Help / Joomla! Help. The second item in the index is Latest Version Check. In Joomla 3 there is a warning if the installed version is not the current version and then a list of Announcements and Release notes going back through all major/minor/patch versions of the 3.x series. They link to the Release News pages. There are also Frequently Asked Questions for each major/minor/patch release. They are actually bug reports, are sparce and don't work properly when delivered by the Help proxy server. All of this has accumulated well over 400 Help support files. The Version Check is redundant because the Home dashboard does that check anyway in Joomla 4.

In Joomla 4 the Latest Version Check Help link returns a 404 not found page because there are no Help support pages (yet).

This PR removes that Help page and the code required to generate it - all in com_admin.

Actual result BEFORE applying this Pull Request

The Latest Version Check page is present in the Joomla! Help index for Joomla 4 but returns an error page.

Expected result AFTER applying this Pull Request

The Latest Version Check page is absent from the Joomla! Help index for Joomla 4.

Documentation Changes Required

None

avatar ceford ceford - open - 10 Oct 2020
avatar ceford ceford - change - 10 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Oct 2020
Category Administration com_admin
avatar brianteeman
brianteeman - comment - 11 Oct 2020

The difference between the update check on the dashboard and the help page is that as you identified the help page includes

in Joomla 3 there is a warning if the installed version is not the current version and then a list of Announcements and Release notes going back through all major/minor/patch versions of the 3.x series.

I dont see a good reason for removing this link - or am I missing something

avatar ceford
ceford - comment - 11 Oct 2020

For Joomla 3 have a look at these two pages:
https://help.joomla.org/proxy/index.php?keyref=Help39:Joomla_Version_3_9_21/en&lang=en
https://help.joomla.org/proxy/index.php?keyref=Help39:Joomla_Version_3_9_20/en&lang=en
They are identical. So are all of the others through the the 3 series, hundreds of them. Except that of the current release which does not have the Warning message.
Have a look at this:
https://docs.joomla.org/Category:Version_3.9.22_FAQ
And compare it with this:
https://help.joomla.org/proxy/index.php?keyref=Category:Version_3.9.22_FAQ
The second version does not show the reported bug. And they are rare anyway.
If I try to fill out the form to create a FAQ I get taken here:
https://docs.joomla.org/Main_Page
Whatever we are trying to do we are doing it wrong!
It would be nice to have a page with abstracts of Release Announcements - but just one page. Separate issue?
And Bugs should be Bugs and not FAQS.

avatar brianteeman
brianteeman - comment - 11 Oct 2020

Everything you describe is accurate but the solution is not to remove the link here. The solution to all of them lies with the docs site

avatar MartijnMaandag
MartijnMaandag - comment - 12 Oct 2020

I am sorry, the label says: "Latest version check"
I agree with Cliff that it is a duplicate of the automated version check in Joomla itself. If you don't see the automated one, you will never find this one in the helpscreens.
I always wondered why I did always have to translate these new release-notes and did not do it the latest 3.9 release. I do see now where it is used and that, if you don't translate the latest version, the hole is in Englisch and not translated.
So this is not a good version check and we must remove it from J4. If there is a need for additional version information, we must add this and create something on the docs to support this.

avatar ceford ceford - change - 12 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2020
Category Administration com_admin Administration com_admin Language & Strings
avatar tushar33 tushar33 - test_item - 17 Oct 2020 - Tested successfully
avatar tushar33
tushar33 - comment - 17 Oct 2020

I have tested this item successfully on e63d29f

Showing expected result


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31038.

avatar karo3 karo3 - test_item - 17 Oct 2020 - Tested unsuccessfully
avatar karo3
karo3 - comment - 17 Oct 2020

I have tested this item ? unsuccessfully on e63d29f

The link will be removed, so that works. But the div container with the class row lacks the spacing class mt-sm-3. The PR must therefore be corrected at this point.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31038.

avatar Giuse69
Giuse69 - comment - 17 Oct 2020

yes, just modify line 21 in administrator/components/com_admin/tmpl/help/default.php
from
<div class="row">
to
<div class="row mt-sm-3">
but strangely that line is not marked as modified in the "files changed" tab...why?

avatar ceford ceford - change - 18 Oct 2020
Labels Added: ?
avatar ceford
ceford - comment - 18 Oct 2020

I don't understand why the php72-unit test is failing. Have I done something wrong? I did start a local build accidentally and cancelled it before it went very far.

avatar HLeithner
HLeithner - comment - 18 Oct 2020

I restarted drone

avatar Quy Quy - test_item - 22 Oct 2020 - Tested successfully
avatar Quy
Quy - comment - 22 Oct 2020

I have tested this item successfully on d158b2d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31038.

avatar richard67 richard67 - test_item - 22 Oct 2020 - Tested successfully
avatar richard67
richard67 - comment - 22 Oct 2020

I have tested this item successfully on d158b2d

The PR does what it claims to do, and all these links to release note pages are not very helpful anyway, and the version check we have elsewhere.

So for me it's ok to remove that page.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31038.

avatar richard67 richard67 - change - 22 Oct 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31038.

avatar rdeutz rdeutz - close - 27 Oct 2020
avatar rdeutz rdeutz - merge - 27 Oct 2020
avatar rdeutz rdeutz - change - 27 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-27 13:24:17
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment