[#31009] - Fix ksort type
- Closed
- 9 Oct 2020
- Medium
- Build: staging
- # 31009
- Diff
- N6REJ:30979
User tests: Successful: Unsuccessful:
Pull Request for Issue # 30979
Summary of Changes
changed to integer per https://www.w3schools.com/php/func_array_ksort.asp
Testing Instructions
go to global configuration
set debug to yes
set log to development
go to administrator/index.php?option=com_templates&view=template&id=506
observer php warning exists
apply pr
refresh page verify that error is gone.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository Administration com_templates |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-09 06:01:09 |
| Closed_By | ⇒ | N6REJ | |
| Labels |
Added:
?
|
||
You can't just replace an undefined constant with a random value. Passing an unrecognized flag, my guess, will result in default value being used. ksort() simply doesn't support natural sorting on PHP 5.3, no matter what you pass. Not to mention values of constants can change between PHP versions.
it's not a random value.. read the docs
Unrelated changes aside, this PR is wrong.