[#31008] - Remove redundant character escape "\" in RegExp
- Closed
- 1 Apr 2021
- Medium
- Build: staging
- # 31008
- Diff
- PhilETaylor:patch-22
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Remove redundant character escape "" in RegExp
Testing Instructions
use bump.php :-)
Also code review, here is a quick unit test where you can see it still compiles and gives the same result
Actual result BEFORE applying this Pull Request
Everything works
Expected result AFTER applying this Pull Request
Everything works
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
I hope you used a tool for this ;-) I will test this later thanks
Im just a very very critical person always looking for the smallest thing to complain about - apparently :)
That's good if you always (or at least sometimes) include the PR like here ;-)
Like I have said elsewhere, Sometimes its better to have 20 Issues raised that took the same time as 1 PR, as then Unlimited number of contributors can see the problems clearly documented, and can contribute to fixing the 20 issues reported and the project wins. Plus, it seems no one else is actually doing any structured strategic testing of Joomla 4 apart from me. Plus I code for a day job, sometimes sat on the sofa infront of the TV, or on the kitchen table cooking for the kid its nice to have a change from code... and that is testing for me, and I seem to be kinda good at testing (very very critical person always looking for the smallest thing to complain about) as my track record shows (apparently)... haha
Title is ´[4]´, but its staging.
Changed.
| Title |
|
||||||
Closed as no chance of being merged after being kicked down the road this long.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-01 16:26:34 |
| Closed_By | ⇒ | PhilETaylor |
appveyor build filling is unrelated to PR changes.