? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
8 Oct 2020

Summary of Changes

The SVG is declaring a namespace it doesn't then go on to use, therefore its redundant (and phpStorm says that)

Testing Instructions

code review

The SVG is still valid with this namespace removed

example (with red background to show white SVG)

https://codepen.io/philetaylor/pen/GRqgNWq

Actual result BEFORE applying this Pull Request

"Namespace declaration is never used" warning in XML Inspector in phpStorm
Extra markup rendered with no use

Expected result AFTER applying this Pull Request

No warnings. Smaller filesize ;-)

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 8 Oct 2020
avatar PhilETaylor PhilETaylor - change - 8 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2020
Category Repository
avatar wilsonge wilsonge - change - 15 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-15 21:46:04
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 Oct 2020
avatar wilsonge wilsonge - merge - 15 Oct 2020
avatar wilsonge
wilsonge - comment - 15 Oct 2020

Thanks!

Add a Comment

Login with GitHub to post a comment