Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31006] - [4] Remove Unnecessary Local Variable

? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
8 Oct 2020

Summary of Changes

Remove Unnecessary Local Variable

Its not good practice to create a variable just before using it once and returning.

Highlighted by #phpStorm code smell.

Testing Instructions

Code review.

Documentation Changes Required

None.

avatar PhilETaylor PhilETaylor - open - 8 Oct 2020
avatar PhilETaylor PhilETaylor - change - 8 Oct 2020
Status New ⇒ Pending
avatar Quy Quy - test_item - 8 Oct 2020 - Tested successfully
avatar Quy
Quy - comment - 8 Oct 2020

I have tested this item ✅ successfully on fff28d7

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31006.

avatar rdeutz rdeutz - close - 9 Oct 2020
avatar rdeutz rdeutz - merge - 9 Oct 2020
avatar rdeutz rdeutz - change - 9 Oct 2020
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-09 06:45:17
Closed_By ⇒ rdeutz
Labels Added: ?
avatar ceford ceford - test_item - 9 Oct 2020 - Tested successfully
avatar ceford
ceford - comment - 9 Oct 2020

I have tested this item ✅ successfully on fff28d7

Confirmed one code change applied.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31006.

Add a Comment

Login with GitHub to post a comment