User tests: Successful: Unsuccessful:
Hi,
while supporting our component we come often across people who want to change the language output.
It has to be explained then in which file the string can be found so that it can be edited.
With the new version of Joomla! it is possible to create language overrides so that the changes aren't lost anymore during the updates. This is great, but the user still has to find the correct language file in order to detect which language constant he has to override.
With this pull request I'd like to suggest a new manager which simplifies that.
It's a new tab in language manager in which users can create language overrides for any installed language.
In the edit view a search can be done for language strings the user wants to change. The script will then take completely care of the override.ini files.
This way people can change any language output of their site without having to know anything about language constants or override.ini files.
Please let me know what you think about that.
Regards
Chraneco
hello,
I like the idea. Would be a good addition. :)
I tested your patch:
Remarks:
1. Post the proposal as a patch in the feature tracker with
instructions of use (i.e. create the new table, etc.)
2. You are modifying /media/system/js/mootools-core-uncompressed.js
and I guess this is an oversight.
3. "Search text you want to change" is not working here
4. Not standard coding
regards
JM
Hi,
while supporting our component we come often across people who want
to change the language output.
It has to be explained then in which file the string can be found so
that it can be edited.With the new version of Joomla! it is possible to create language
overrides so that the changes aren't lost anymore during the
updates. This is great, but the user still has to find the correct
language file in order to detect which language constant he has to
override.With this pull request I'd like to suggest a new manager which
simplifies that.
It's a new tab in language manager in which users can create
language overrides for any installed language.In the edit view a search can be done for language strings the user
wants to change. The script will then take completely care of the
override.ini files.This way people can change any language output of their site without
having to know anything about language constants or override.ini
files.Please let me know what you think about that.
Regards
ChranecoYou can merge this Pull Request by running:
git pull https://github.com/Chraneco/joomla-cms master
Or you can view, comment on it, or merge it online at:
-- Commit Summary --
- Initial Commit for Language Overrides Manager
- Merge remote-tracking branch 'upstream/master'
- Clean up - Small improvements - Code Style
- Accidentally commited file removed
- 'No Results' message added
-- File Changes --
A administrator/components/com_languages/controllers/override.php (200)
A administrator/components/com_languages/controllers/overrides.php (69)
A administrator/components/com_languages/controllers/strings.json.php (63)
A administrator/components/com_languages/helpers/jsonresponse.php (127)
M administrator/components/com_languages/helpers/languages.php (97)
A administrator/components/com_languages/models/forms/override.xml (37)
A administrator/components/com_languages/models/override.php (168)
A administrator/components/com_languages/models/overrides.php (205)
A administrator/components/com_languages/models/strings.php (162)
M
administrator/components/com_languages/views/installed/tmpl/default_navigation.php
(2)
A administrator/components/com_languages/views/override/index.html (1)
A administrator/components/com_languages/views/override/tmpl/edit.php (88)
A administrator/components/com_languages/views/override/tmpl/index.html (1)
A administrator/components/com_languages/views/override/view.html.php (132)
A administrator/components/com_languages/views/overrides/index.html (1)
A administrator/components/com_languages/views/overrides/tmpl/default.php (99)
A administrator/components/com_languages/views/overrides/tmpl/index.html (1)
A administrator/components/com_languages/views/overrides/view.html.php (112)
M administrator/language/en-GB/en-GB.com_languages.ini (30)
M installation/sql/mysql/joomla.sql (15)
A media/overrider/css/index.html (1)
A media/overrider/css/overrider.css (53)
A media/overrider/index.html (1)
A media/overrider/js/index.html (1)
A media/overrider/js/overrider.js (199)
M media/system/js/mootools-core-uncompressed.js (2)-- Patch Links --
https://github.com/joomla/joomla-cms/pull/31.patch
https://github.com/joomla/joomla-cms/pull/31.diff
Reply to this email directly or view it on GitHub:
#31
Please keep the Subject wording in your answers
This e-mail and any attachments may be confidential. You must not
disclose or use the information contained in this e-mail if you are
not the
intended recipient. If you have received this e-mail in error, pleasenotify us immediately and delete the e-mail and all copies.
Jean-Marie Simonet / infograf768
Joomla Production Working group
Joomla! Translation Coordination Team
Hi,
thank you very much for your feedback.
Post the proposal as a patch in the feature tracker with instructions of use (i.e. create the new table, etc.)
The created tracker item can be found here:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27320
Hopefully I created the patch file correctly (I'm new to Github)
One new database table has to be created additionally:
CREATE TABLE IF NOT EXISTS #__overrider
(id
int(10) NOT NULL AUTO_INCREMENT COMMENT 'Primary Key',constant
varchar(255) NOT NULL,string
text NOT NULL,file
varchar(255) NOT NULL,
PRIMARY KEY (id
)
) DEFAULT CHARSET=utf8;
You are modifying /media/system/js/mootools-core-uncompressed.js and I guess this is an oversight.
Sorry, this was indeed unintentional, I reverted it.
"Search text you want to change" is not working here
This may have several causes:
A JavaScript error occured. Hopefully this is solved with my last commits. I tested it with Firefox 8, Opera 11.60, Safari 5.1.2 and Internet Explorer 9 so far.
The database table didn't exist (I should have mentioned that there's a new one).
An SQL error occured. With commit d447c14 the third argument '), (' for instantiating JDatabaseQueryElement (line 1165) in method 'values' of file 'databasequery.php' was removed. I think the method 'values' cannot be used as usual anymore due to that. As a workaround I create one of the queries in model 'strings.php' manually now (without using JDatabaseQuery).
Not standard coding
Do you mean the code style?
I tried to apply that code style guide:
http://developer.joomla.org/standards/
but I guess it holds only for the platform?
Which style guide do I have to use?
Regards
Chraneco
Hi. If you haven't done so, please add an issue in the Feature Tracker
here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549.
Thanks! Mark Dexter
On Tue, Dec 6, 2011 at 12:55 PM, Chraneco
reply@reply.github.com
wrote:
Hi,
while supporting our component we come often across people who want to change the language output.
It has to be explained then in which file the string can be found so that it can be edited.With the new version of Joomla! it is possible to create language overrides so that the changes aren't lost anymore during the updates. This is great, but the user still has to find the correct language file in order to detect which language constant he has to override.
With this pull request I'd like to suggest a new manager which simplifies that.
It's a new tab in language manager in which users can create language overrides for any installed language.In the edit view a search can be done for language strings the user wants to change. The script will then take completely care of the override.ini files.
This way people can change any language output of their site without having to know anything about language constants or override.ini files.
Please let me know what you think about that.
Regards
ChranecoYou can merge this Pull Request by running:
git pull https://github.com/Chraneco/joomla-cms master
Or you can view, comment on it, or merge it online at:
-- Commit Summary --
- Initial Commit for Language Overrides Manager
- Merge remote-tracking branch 'upstream/master'
- Clean up - Small improvements - Code Style
- Accidentally commited file removed
- 'No Results' message added
-- File Changes --
A administrator/components/com_languages/controllers/override.php (200)
A administrator/components/com_languages/controllers/overrides.php (69)
A administrator/components/com_languages/controllers/strings.json.php (63)
A administrator/components/com_languages/helpers/jsonresponse.php (127)
M administrator/components/com_languages/helpers/languages.php (97)
A administrator/components/com_languages/models/forms/override.xml (37)
A administrator/components/com_languages/models/override.php (168)
A administrator/components/com_languages/models/overrides.php (205)
A administrator/components/com_languages/models/strings.php (162)
M administrator/components/com_languages/views/installed/tmpl/default_navigation.php (2)
A administrator/components/com_languages/views/override/index.html (1)
A administrator/components/com_languages/views/override/tmpl/edit.php (88)
A administrator/components/com_languages/views/override/tmpl/index.html (1)
A administrator/components/com_languages/views/override/view.html.php (132)
A administrator/components/com_languages/views/overrides/index.html (1)
A administrator/components/com_languages/views/overrides/tmpl/default.php (99)
A administrator/components/com_languages/views/overrides/tmpl/index.html (1)
A administrator/components/com_languages/views/overrides/view.html.php (112)
M administrator/language/en-GB/en-GB.com_languages.ini (30)
M installation/sql/mysql/joomla.sql (15)
A media/overrider/css/index.html (1)
A media/overrider/css/overrider.css (53)
A media/overrider/index.html (1)
A media/overrider/js/index.html (1)
A media/overrider/js/overrider.js (199)
M media/system/js/mootools-core-uncompressed.js (2)-- Patch Links --
https://github.com/joomla/joomla-cms/pull/31.patch
https://github.com/joomla/joomla-cms/pull/31.diff
Reply to this email directly or view it on GitHub:
#31
Hi,
I already handed the link in with my second post above, but here it is again for completeness:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27320
Regards
Chraneco
Going on now the discussion on tracker
WOuld you send a pull request to https://github.com/elinw/joomla-cms/tree/pbf2011 please so it can be tested in pbf.
Hi,
I'm not sure how to do that (I'm new to Github).
If I click on 'Pull Request' it wants to edit the current pull request rather than create a new one for another branch.
Shall I simply change it to yours?
Regards
Chraneco
Thank you very much!
Please add this proposal in the Feature Tracker with the .diff as a file. Thanks.