Pending

User tests: Successful: Unsuccessful:

avatar eddieajau
eddieajau
6 Dec 2011

This patch adds the ability to attach notes to a user.

Adds:

  • User notes list view and edit page.
  • User notes categories
  • Registered date filter to list view

The patch also modifies the main user list. In a new site, there will be an "Add Note" icon against each user. This will link to a note edit form where you can add a note with a subject, description, category and review date.

When notes are added to a user the main user list shows two more icons: an icon that links to a modal popup summary of the notes, and an icon to jump to the full notes list filtering on that user.

Feature tracker reference: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

avatar eddieajau eddieajau - open - 6 Dec 2011
avatar elinw
elinw - comment - 10 Dec 2011

please send a pull request to https://github.com/elinw/joomla-cms/tree/pbf2011 for pbf to test

avatar mbabker mbabker - reference | - 10 Dec 11
avatar mbabker mbabker - reference | - 10 Dec 11
avatar elinw
elinw - comment - 10 Dec 2011

The code is looking for JHtml::users but there is no such thing in the pull request.

avatar realityking
realityking - comment - 10 Dec 2011

It's part of the platform and will be part of the next merge.

avatar eddieajau
eddieajau - comment - 14 Dec 2011

Closes #20

Added registration search range from @drmmr763

avatar eddieajau eddieajau - reference | - 15 Dec 11
avatar eddieajau
eddieajau - comment - 17 Dec 2011

Method signature fixed. Also added missing bits to the Hathor users view, default layout. However, I'm not familiar with what is required for new view layouts in Hathor (not sure that's really my responsibility, but anyway). If there's documentation you can point me to to guide me through how to do that I can take a stab at it, otherwise I think that should be the responsibility of the experts that maintain Hathor (in which case, just shoot me a pull request).

avatar chdemko
chdemko - comment - 18 Dec 2011

Ok, I will ask Andrea to create the layout for Hathor.

Currently, the pull request cannot be merged

avatar eddieajau
eddieajau - comment - 18 Dec 2011

Merge conflict fixed.

avatar chdemko chdemko - reference | - 18 Dec 11
avatar chdemko chdemko - merge - 18 Dec 2011
avatar chdemko chdemko - close - 18 Dec 2011
avatar realityking
realityking - comment - 18 Dec 2011

A suggestions for the future: Could we please only merge big pull requests like this after they've been rebased into just a couple of commits (the less the better, but at least one per author is required). This would make the commit history much more meaningful and easier to read.

It's really not needed to follow how a feature grew to be, when I browse the history I just wanna see the when the feaute hit the repro.

avatar nonumber nonumber - reference | - 24 Jul 12
avatar garyamort garyamort - reference | - 2 Dec 13
avatar N6REJ N6REJ - reference | a111704 - 6 Jan 15
avatar N6REJ N6REJ - reference | f66dd92 - 6 Jan 15

Add a Comment

Login with GitHub to post a comment