Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
5 Dec 2011

This is the pull request coinciding with http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27221.

This improves the batch processing throughout the CMS for Joomla! 2.5. Included in this pull request:

  • All components: Improved ACL checks for create and edit permissions
  • com_banners: Full batch processing implementation (category, language, and client)
  • com_contact: Full batch processing implementation (access, category, language, and linked user)
  • com_content: Handles featured articles during copy process (see
  • com_modules: Full batch processing implementation (access, copy/move between positions, language)
  • com_newsfeeds: Full batch processing implementation (access, category, and language)
  • com_users: Implement unused batch processing code for group assignment

This item also references CMS issues [#26905] and [#26986].

One TODO item remains as of this time: Implementing batch processing logic for menu associations (I've been looking at this, and hope to have something ready soon)

Also, to assist with conforming to coding standards, in many of the files that I've edited, I've applied the coding standard from the Platform into my edited files.

This change edits several library files as well; a separate pull request for the Platform is forthcoming.

avatar mbabker mbabker - open - 5 Dec 2011
avatar mbabker mbabker - reference | - 5 Dec 11
avatar mbabker mbabker - reference | - 10 Dec 11
avatar infograf768
infograf768 - comment - 20 Dec 2011

Copying Module and changing language without changing position just changes the language of the module chosen

avatar mbabker
mbabker - comment - 21 Dec 2011

Fixed issue with module copy/move.

avatar chdemko
chdemko - comment - 30 Dec 2011

The pull request cannot be merged
Could you make a pull request on the platform for the changes?

avatar mbabker
mbabker - comment - 30 Dec 2011

The changes to JControllerForm are already in the platform (not sure why it didn't merge in on the last platform merge). The fix for the user list I'll take care of later.

Merged from master, so should merge cleanly for a short time.

avatar infograf768
infograf768 - comment - 31 Dec 2011

Don't want to be pushy, but this patch includes a lot of new language strings and we get nearer to beta2 /RC.
We will have to declare a language freeze at some time.

avatar mbabker
mbabker - comment - 31 Dec 2011

I've just pushed the last set of fixes for the issues @chdemko reported.

Can we merge soon?

avatar infograf768
infograf768 - comment - 1 Jan 2012

Saw more errors. Commented on tracker.

avatar infograf768
infograf768 - comment - 2 Jan 2012

Modules copying still broken when choosing language and no change in position

avatar mbabker mbabker - reference | - 2 Jan 12
avatar chdemko
chdemko - comment - 2 Jan 2012

Why did you rename administrator/components/{com_users → com_banners}/helpers/html/index.html ? (should be a copy?)

avatar mbabker
mbabker - comment - 2 Jan 2012

No idea why it's being tracked as a rename. I'll sort that once I'm back on my computer.

-Michael

Please pardon any errors, this message was sent from my iPhone.

On Jan 2, 2012, at 2:24 PM, Christophe Demko reply@reply.github.com wrote:

Why did you rename administrator/components/{com_users → com_banners}/helpers/html/index.html ? (should be a copy?)


Reply to this email directly or view it on GitHub:
#29 (comment)

avatar chdemko chdemko - reference | - 3 Jan 12
avatar chdemko chdemko - merge - 3 Jan 2012
avatar chdemko chdemko - close - 3 Jan 2012
avatar garyamort garyamort - reference | - 2 Dec 13
avatar roland-d roland-d - reference | 97ba678 - 16 Feb 16

Add a Comment

Login with GitHub to post a comment