Pending

User tests: Successful: Unsuccessful:

avatar eddieajau
eddieajau
8 Dec 2011

Saving a module produces an SQL error due to incorrect usage of the query builder. JDatabaseQuery::values takes a whole tuple of values or an array of tuples (which differs from the columns method which can add to the list of columns with subsequent calls).

Patch also adds some other common files to .gitignore.

NOTE: Error is occurring against the master git platform, not Joomla's copy of /libraries/joomla/.

avatar eddieajau eddieajau - open - 8 Dec 2011
avatar dextercowley
dextercowley - comment - 8 Dec 2011

Andrew, is there a tracker issue associated with this? Thanks. Mark

On Thu, Dec 8, 2011 at 1:42 AM, Andrew Eddie
reply@reply.github.com
wrote:

Saving a module produces an SQL error due to incorrect usage of the query builder.  JDatabaseQuery::values takes a whole tuple of values or an array of tuples (which differs from the columns method which can add to the list of columns with subsequent calls).

Patch also adds some other common files to .gitignore.

You can merge this Pull Request by running:

 git pull https://github.com/eddieajau/joomla-cms bugs

Or you can view, comment on it, or merge it online at:

 #32

-- Commit Summary --

  • Fix SQL when trying to save a module due to query build error.
  • Add extra ignore filters for common files.

-- File Changes --

M .gitignore (6)
M administrator/components/com_modules/models/module.php (5)

-- Patch Links --

 https://github.com/joomla/joomla-cms/pull/32.patch
 https://github.com/joomla/joomla-cms/pull/32.diff


Reply to this email directly or view it on GitHub:
#32

avatar eddieajau
eddieajau - comment - 8 Dec 2011

No. The problem is actually more widespread. I'll ping you about it.

avatar elinw elinw - reference | - 11 Dec 11
avatar eddieajau
eddieajau - comment - 12 Dec 2011

Closing.

avatar eddieajau eddieajau - close - 12 Dec 2011
avatar wilsonge wilsonge - reference | - 29 Aug 13
avatar N6REJ N6REJ - reference | 74e28bf - 6 Jan 15

Add a Comment

Login with GitHub to post a comment